-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extraneous <global> symbol from Salsa #11230
Comments
The top level entry in I do not think this is a change on the server side, but on VSCode side. closing. |
@mhegazy what is the reason to have that in in the first place for JS. This is requesting symbols for a specific document. As I understand the it is about global symbols. And for TS files it looks like we are not receiving such a global entry. So fixing this on our end seems a little wired. |
I debugged it a little and the returned structure is as follows;
So there is no single entry :-) |
There is more wiredness: function foo() {
function bar() {
function faz() {
}
}
} Produces the following Nav item tree
|
The issue here is that I think the best solution here is to add a new command to the server, I have logged #11250 to track adding the new command. If you are interested in reverse-serializing the output of navBar, here is the algorithm:
|
From @mousetraps on September 28, 2016 20:40
Testing #12598
Copied from original issue: microsoft/vscode#12936
The text was updated successfully, but these errors were encountered: