-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Node.cloneNode returns the wrong type #17818
Comments
Can I take this up as a starting point? Seems straight forward if the issue creator is correct about the change. |
PRs welcomed. You can find more information about contributing lib.d.ts fixes at https://github.com/Microsoft/TypeScript/blob/master/CONTRIBUTING.md#contributing-libdts-fixes. |
One thing to note, we do not want to add |
duplicate of the older ref #283 |
Automatically closing this issue for housekeeping purposes. The issue labels indicate that it is unactionable at the moment or has already been addressed. |
Node.cloneNode should return the type of "this". Therefore this line
https://github.com/Microsoft/TypeScript/blob/93abebc04af5d443a930ad84258cf2d6101d8513/lib/lib.es6.d.ts#L14166
should be
cloneNode(deep?: boolean): this;
The text was updated successfully, but these errors were encountered: