Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSX: Add a way to specify children as not a part of props #18357

Open
dfilatov opened this issue Sep 9, 2017 · 2 comments
Open

JSX: Add a way to specify children as not a part of props #18357

dfilatov opened this issue Sep 9, 2017 · 2 comments
Labels
Domain: JSX/TSX Relates to the JSX parser and emitter In Discussion Not yet reached consensus Suggestion An idea for TypeScript

Comments

@dfilatov
Copy link

dfilatov commented Sep 9, 2017 •
edited
Loading

Right now there's no way to specify what children representation is, except specifying ElementChildrenAttribute inside JSX namespace. It's heavily coupled with React representation for children which implies that children is a part of props. This makes impossible to enable type checking for children with implementations which store children separately, for instance https://github.com/dfilatov/vidom/wiki/Component-properties.
Probably it could be ElementChildrenProperty (like ElementAttributesProperty).
@DanielRosenwasser DanielRosenwasser added Domain: JSX/TSX Relates to the JSX parser and emitter Suggestion An idea for TypeScript labels Sep 9, 2017
@matt-gadd matt-gadd mentioned this issue Sep 18, 2017
Open
@dfilatov
Copy link
Author

@DanielRosenwasser Daniel, sorry for bothering, but could you or someone from your great team comment this somehow?

@mhegazy
Copy link
Contributor

mhegazy commented Feb 13, 2018

related to #21699

@aaronjensen aaronjensen mentioned this issue Feb 14, 2018
Open
@agubler agubler mentioned this issue Jul 30, 2018
Closed
@weswigham weswigham added the In Discussion Not yet reached consensus label Nov 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Domain: JSX/TSX Relates to the JSX parser and emitter In Discussion Not yet reached consensus Suggestion An idea for TypeScript
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@dfilatov @DanielRosenwasser @weswigham @mhegazy