Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sortText not set on property completions if triggered without typing #30013

Closed
mjbvz opened this issue Feb 21, 2019 · 3 comments
Closed

sortText not set on property completions if triggered without typing #30013

mjbvz opened this issue Feb 21, 2019 · 3 comments
Assignees
Labels
Bug A bug in TypeScript Duplicate An existing issue was already created

Comments

@mjbvz
Copy link
Contributor

mjbvz commented Feb 21, 2019

TypeScript Version: 3.4.0-dev.20190220

Search Terms:

  • completions
  • suggestions
  • sortText

Code
For the TypeScript code:

class Foo {
    prop: number;

    render() {
        
    }
}

Trigger suggestions in render using ctrl+space instead of typing

Expected behavior:
The suggestions for prop and render should have a higher sortText value. This is what we see when suggestions are triggered after you start typing:

class Foo {
    prop: number;

    render() {
        t|
    }
}

Actual behavior:
The sortText is "0" for all suggestions, including those for properties

Playground Link:

Related Issues:

@mjbvz mjbvz changed the title sortText not set on property completions if triggered sortText not set on property completions if triggered without typing Feb 21, 2019
@RyanCavanaugh RyanCavanaugh added the Bug A bug in TypeScript label Feb 27, 2019
@RyanCavanaugh RyanCavanaugh added this to the TypeScript 3.5.0 milestone Feb 27, 2019
@sheetalkamat
Copy link
Member

@mjbvz I don't see any difference between getting completions with ctr+space or typing.
The sort text issue is #15024
tsserver.log

@sheetalkamat sheetalkamat added Needs More Info The issue still hasn't been fully clarified and removed Needs More Info The issue still hasn't been fully clarified labels May 16, 2019
@sheetalkamat
Copy link
Member

So duplicate of #15024 ?

@mjbvz
Copy link
Contributor Author

mjbvz commented May 17, 2019

Yes, this falls under #15024

@mjbvz mjbvz closed this as completed May 17, 2019
@mjbvz mjbvz added the Duplicate An existing issue was already created label May 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A bug in TypeScript Duplicate An existing issue was already created
Projects
None yet
Development

No branches or pull requests

3 participants