Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide quick fixes for useDefineForClassFields breaks #34788

Closed
DanielRosenwasser opened this issue Oct 28, 2019 · 1 comment · Fixed by #37894
Closed

Provide quick fixes for useDefineForClassFields breaks #34788

DanielRosenwasser opened this issue Oct 28, 2019 · 1 comment · Fixed by #37894
Assignees
@sandersn
Labels
Domain: Quick Fixes Editor-provided fixes, often called code actions. Suggestion An idea for TypeScript
Milestone
TypeScript 4.0.0

Comments

@DanielRosenwasser
Copy link
Member

Since this targets 3.7.1, I'm going to close this bug. When class fields reaches stage 4, I'll do the final two steps.

Originally posted by @sandersn in #27644 (comment)

Provide a quick fix to fix these breaks.
@DanielRosenwasser DanielRosenwasser added Suggestion An idea for TypeScript Domain: Quick Fixes Editor-provided fixes, often called code actions. labels Oct 28, 2019
@DanielRosenwasser DanielRosenwasser added this to the TypeScript 3.8.0 milestone Oct 28, 2019
@DanielRosenwasser DanielRosenwasser mentioned this issue Nov 4, 2019
Closed
@sandersn
Copy link
Member

sandersn commented Jan 7, 2020

Moving to 3.9 until class fields reach stage 4.

@sandersn sandersn mentioned this issue Apr 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sandersn sandersn

Labels
Domain: Quick Fixes Editor-provided fixes, often called code actions. Suggestion An idea for TypeScript
Projects
None yet
Milestone
TypeScript 4.0.0
Development

Successfully merging a pull request may close this issue.

Always error on property override accessor microsoft/TypeScript
2 participants
@sandersn @DanielRosenwasser