Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Registry ATA uses should be configurable #35038

Closed
sandersn opened this issue Nov 11, 2019 · 1 comment
Closed

Registry ATA uses should be configurable #35038

sandersn opened this issue Nov 11, 2019 · 1 comment
Assignees
Labels
Bug A bug in TypeScript Committed The team has roadmapped this issue Rescheduled This issue was previously scheduled to an earlier milestone

Comments

@sandersn
Copy link
Member

Currently typingsInstaller always uses the NPM registry to install types-registry and @types/* packages. #33791 makes it use the github package registry for types-registry, with a fallback to NPM. But this is hard-coded. Instead the editor should pass a flag to typingsInstaller that specifies the registry to use.

It is fine if NPM is still the fallback -- in fact it is desirable until we're confident in github's ability to host packages.

@sandersn sandersn self-assigned this Nov 11, 2019
@sandersn sandersn added Bug A bug in TypeScript Committed The team has roadmapped this issue labels Nov 11, 2019
@sandersn sandersn added this to the TypeScript 3.8.0 milestone Nov 11, 2019
@RyanCavanaugh RyanCavanaugh added the Rescheduled This issue was previously scheduled to an earlier milestone label Dec 11, 2020
@sandersn
Copy link
Member Author

sandersn commented Feb 2, 2022

After discussing this, we decided that this feature doesn't make sense with Microsoft owning both github and npm. There's no gain in redundancy anymore.

@sandersn sandersn closed this as completed Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A bug in TypeScript Committed The team has roadmapped this issue Rescheduled This issue was previously scheduled to an earlier milestone
Projects
None yet
Development

No branches or pull requests

4 participants