Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Windows contributor requirements to run Windows 10 #35991

Open
DanielRosenwasser opened this issue Jan 4, 2020 · 1 comment
Open
Labels
Discussion Issues which may not have code impact Infrastructure Issue relates to TypeScript team infrastructure

Comments

@DanielRosenwasser
Copy link
Member

We recently ran into a situation where git errored during a checkout due to a file path that was too long.

#35711 (comment)

To get around this, we can run

git config core.longpaths true

However, it seems that this option requires Windows users to run Windows 10. It doesn't affect other users.

Everyone on the core team who's on Windows is basically on the latest version, and we don't have reason to believe at the moment that this affects many external contributors. As a result, we will likely turn on the flag and adjust appropriately if this becomes an issue.

@DanielRosenwasser DanielRosenwasser added Discussion Issues which may not have code impact Infrastructure Issue relates to TypeScript team infrastructure labels Jan 4, 2020
@DanielRosenwasser
Copy link
Member Author

Actually, it seems unclear from the documentation what the situation is.

https://docs.microsoft.com/en-us/windows/win32/fileio/naming-a-file?redirectedfrom=MSDN#enable-long-paths-in-windows-10-version-1607-and-later

At the moment, it seems to be an opt-in thing, but it's turned on for my machine. Doesn't seem like we can definitely turn it on, so we'll be careful with our path lengths.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Discussion Issues which may not have code impact Infrastructure Issue relates to TypeScript team infrastructure
Projects
None yet
Development

No branches or pull requests

1 participant