-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
'declare method' quick fix for adding a private method #37782
Comments
I am the original one complaining about this: what I expect is NOT having 1 code action per visibility, but rather ONE code action (as today) with a tab-stop at the visibility that I can flip the various visibilities. I realise this may need support from VSCode too. Here is how it would work:
|
@DanielRosenwasser Is there a way to have a sub action to handle |
Could you explain what you mean by |
|
Tabstops are from VS Code's snippets: https://code.visualstudio.com/docs/editor/userdefinedsnippets#_tabstops There is no concept of tabstops in the TS Server api today since it only talks about text. I've opened #25207 which proposes adding the idea of snippets to typescript |
Right now I see two ways for this issue
@DanielRosenwasser Maybe you have a better idea :) |
Hah, I meant like "I might have an idea of what you mean by tab stops". I think the weird thing is that the rename location already allows you to make something |
To demonstrate what I expect to happen, here is what Eclipse does: Notice how some tab-stops are linked, so renaming the method actually also renames the call! And what VSCode does: Paper cuts:
Can we reopen this or reconsider this? |
Yeah, #37806 partially fixes this but doesn't address the full issue. I'll re-open that so we can unify the two fixes when post-codefix rename locations are available. |
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
|
@DanielRosenwasser is it still open? |
From microsoft/vscode#94118
TypeScript Version: 3.9.0-dev.20200330
Search terms
Repro
For ts file:
index.ts
_baz
Feature request:
#36249 added a quick fix for adding private properties. However there is no quick fix for adding a private method
Playground Link:
Related Issues:
The text was updated successfully, but these errors were encountered: