Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggestion: Can we check properties in a more efficient order during structural comparisons? #38584

Open
amcasey opened this issue May 14, 2020 · 1 comment
Open

Suggestion: Can we check properties in a more efficient order during structural comparisons? #38584

amcasey opened this issue May 14, 2020 · 1 comment
Assignees
@RyanCavanaugh
Labels
Domain: Performance Reports of unusually slow behavior Needs Investigation This issue needs a team member to investigate its status.

Comments

@amcasey
Copy link
Member

amcasey commented May 14, 2020

A generalization of #38583: we can't tell without (expensively) resolving a property's type/signature whether it depends on a type variable, but we can heuristically check whether it syntactically appears to depend on one. If this heuristic is good enough, we might be able to check properties in a more efficient order.
@amcasey amcasey added the Domain: Performance Reports of unusually slow behavior label May 14, 2020
@amcasey
Copy link
Member Author

amcasey commented May 14, 2020

FYI @DanielRosenwasser

@RyanCavanaugh RyanCavanaugh added the Needs Investigation This issue needs a team member to investigate its status. label May 14, 2020
@amcasey amcasey assigned RyanCavanaugh and unassigned amcasey Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RyanCavanaugh RyanCavanaugh

Labels
Domain: Performance Reports of unusually slow behavior Needs Investigation This issue needs a team member to investigate its status.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@RyanCavanaugh @amcasey