Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash when emitting source maps for skipped nodes (e.g. 'catch' blocks) #39

Closed
mhegazy opened this issue Jul 17, 2014 · 1 comment
Closed

Crash when emitting source maps for skipped nodes (e.g. 'catch' blocks) #39

mhegazy opened this issue Jul 17, 2014 · 1 comment
Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue High Priority
Milestone
TypeScript 1.1

Comments

@mhegazy
Copy link
Contributor

mhegazy commented Jul 17, 2014

Code:

//@sourceMap: true
try {
// ...
} finally {
// N.B. No 'catch' block
}

Call stack:

  TypeError: Cannot read property 'filename' of undefined
@mhegazy mhegazy added this to the TypeScript 1.1 milestone Jul 17, 2014
@sophiajt sophiajt added Fixed and removed Fixed labels Jul 17, 2014
@mhegazy mhegazy assigned vladima and unassigned RyanCavanaugh Jul 31, 2014
@vladima
Copy link
Contributor

vladima commented Jul 31, 2014

Cannot reproduce on the latest bits. Added test fee596b to capture the problem if it will reappear in the future

@vladima vladima closed this as completed Jul 31, 2014
@vladima vladima removed the Fixed label Aug 5, 2014
@Kavignon Kavignon mentioned this issue Dec 1, 2016
Closed
@microsoft microsoft locked and limited conversation to collaborators Jun 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue High Priority
Projects
None yet
Milestone
TypeScript 1.1
Development

No branches or pull requests
5 participants
@sophiajt @ahejlsberg @RyanCavanaugh @mhegazy @vladima