Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add semantic highlighting API to Protocol #42587

Closed
mjbvz opened this issue Feb 1, 2021 · 0 comments · Fixed by #42640
Closed

Add semantic highlighting API to Protocol #42587

mjbvz opened this issue Feb 1, 2021 · 0 comments · Fixed by #42640
Assignees
@orta
Labels
Bug A bug in TypeScript Fix Available A PR has been opened for this issue
Milestone
TypeScript 4.2.1

Comments

@mjbvz
Copy link
Contributor

mjbvz commented Feb 1, 2021

Follow up on #41262

It looks like the encodedSemanticClassifications-full types didn't make it into the protocol.d.ts (I checked 4.2.0-dev.20210201)

The apis seem to work but the types are missing

/cc @orta
@RyanCavanaugh RyanCavanaugh added the Bug A bug in TypeScript label Feb 3, 2021
@RyanCavanaugh RyanCavanaugh added this to the TypeScript 4.2.1 milestone Feb 3, 2021
@orta orta mentioned this issue Feb 4, 2021
Merged
@typescript-bot typescript-bot added the Fix Available A PR has been opened for this issue label Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@orta orta

Labels
Bug A bug in TypeScript Fix Available A PR has been opened for this issue
Projects
None yet
Milestone
TypeScript 4.2.1
Development

Successfully merging a pull request may close this issue.

Expose EncodedSemanticClassificationsRequest in protocol.d.ts orta/TypeScript
4 participants
@orta @RyanCavanaugh @mjbvz @typescript-bot