Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle plugins without specified names #42718

Closed
DanielRosenwasser opened this issue Feb 9, 2021 · 0 comments · Fixed by #42717
Closed

Handle plugins without specified names #42718

DanielRosenwasser opened this issue Feb 9, 2021 · 0 comments · Fixed by #42717
Assignees
@DanielRosenwasser @sheetalkamat
Labels
Bug A bug in TypeScript Crash For flagging bugs which are compiler or service crashes or unclean exits, rather than bad output Domain: TSServer Issues related to the TSServer Fix Available A PR has been opened for this issue
Milestone
TypeScript 4.1.5

Comments

@DanielRosenwasser
Copy link
Member

From microsoft/vscode#116219
Handled at #42717

Patch must be picked to 3.1, 3.7, 3.9, 4.0, and 4.1.

TypeError: Cannot read property 'indexOf' of undefined
    at Object.parsePackageName (/Applications/Visual Studio Code.app/Contents/Resources/app/extensions/node_modules/typescript/lib/tsserver.js:39472:30)
    at ConfiguredProject.Project.enablePlugin (/Applications/Visual Studio Code.app/Contents/Resources/app/extensions/node_modules/typescript/lib/tsserver.js:151962:24)
    at ConfiguredProject.enablePluginsWithOptions (/Applications/Visual Studio Code.app/Contents/Resources/app/extensions/node_modules/typescript/lib/tsserver.js:152477:30)
    at ProjectService.loadConfiguredProject (/Applications/Visual Studio Code.app/Contents/Resources/app/extensions/node_modules/typescript/lib/tsserver.js:154206:25)
    at ProjectService.createAndLoadConfiguredProject (/Applications/Visual Studio Code.app/Contents/Resources/app/extensions/node_modules/typescript/lib/tsserver.js:154145:22)
    at ProjectService.createLoadAndUpdateConfiguredProject (/Applications/Visual Studio Code.app/Contents/Resources/app/extensions/node_modules/typescript/lib/tsserver.js:154150:36)
    at ProjectService.assignProjectToOpenedScriptInfo (/Applications/Visual Studio Code.app/Contents/Resources/app/extensions/node_modules/typescript/lib/tsserver.js:155055:44)
    at /Applications/Visual Studio Code.app/Contents/Resources/app/extensions/node_modules/typescript/lib/tsserver.js:155395:97
    at Object.flatMap (/Applications/Visual Studio Code.app/Contents/Resources/app/extensions/node_modules/typescript/lib/tsserver.js:513:25)
    at ProjectService.applyChangesInOpenFiles (/Applications/Visual Studio Code.app/Contents/Resources/app/extensions/node_modules/typescript/lib/tsserver.js:155395:41)
    at Session.handlers.ts.Map.ts.getEntries._a.<computed> (/Applications/Visual Studio Code.app/Contents/Resources/app/extensions/node_modules/typescript/lib/tsserver.js:156413:46)
    at /Applications/Visual Studio Code.app/Contents/Resources/app/extensions/node_modules/typescript/lib/tsserver.js:158286:88
    at IOSession.Session.executeWithRequestId (/Applications/Visual Studio Code.app/Contents/Resources/app/extensions/node_modules/typescript/lib/tsserver.js:158277:28)
    at IOSession.Session.executeCommand (/Applications/Visual Studio Code.app/Contents/Resources/app/extensions/node_modules/typescript/lib/tsserver.js:158286:33)
    at IOSession.Session.onMessage (/Applications/Visual Studio Code.app/Contents/Resources/app/extensions/node_modules/typescript/lib/tsserver.js:158310:35)
    at Interface.<anonymous> (/Applications/Visual Studio Code.app/Contents/Resources/app/extensions/node_modules/typescript/lib/tsserver.js:160520:27)
    at Interface.emit (events.js:315:20)
    at Interface._onLine (readline.js:329:10)
    at Interface._normalWrite (readline.js:474:12)
    at Socket.ondata (readline.js:186:10)
    at Socket.emit (events.js:315:20)
    at addChunk (_stream_readable.js:295:12)
    at readableAddChunk (_stream_readable.js:271:9)
    at Socket.Readable.push (_stream_readable.js:212:10)
    at Pipe.onStreamRead (internal/stream_base_commons.js:186:23)
@DanielRosenwasser DanielRosenwasser added Bug A bug in TypeScript Domain: TSServer Issues related to the TSServer Crash For flagging bugs which are compiler or service crashes or unclean exits, rather than bad output labels Feb 9, 2021
@DanielRosenwasser DanielRosenwasser added this to the TypeScript 4.1.5 milestone Feb 9, 2021
@sheetalkamat sheetalkamat mentioned this issue Feb 9, 2021
Merged
@typescript-bot typescript-bot added the Fix Available A PR has been opened for this issue label Feb 9, 2021
This was referenced Feb 9, 2021
Merged
Merged
Merged
Merged
Merged
@HolgerJeromin HolgerJeromin mentioned this issue Feb 19, 2021
Closed
This was referenced Mar 8, 2021
Merged
Closed
Merged
Merged
Merged
Closed
Merged
This was referenced Mar 17, 2021
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DanielRosenwasser DanielRosenwasser

@sheetalkamat sheetalkamat

Labels
Bug A bug in TypeScript Crash For flagging bugs which are compiler or service crashes or unclean exits, rather than bad output Domain: TSServer Issues related to the TSServer Fix Available A PR has been opened for this issue
Projects
None yet
Milestone
TypeScript 4.1.5
Development

Successfully merging a pull request may close this issue.

Handle if plugin doesnt specify name microsoft/TypeScript
3 participants
@DanielRosenwasser @sheetalkamat @typescript-bot