Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nodenext alternates between finding and not finding the imported package #46396

Closed
ilogico opened this issue Oct 16, 2021 · 1 comment · Fixed by #46818
Closed

nodenext alternates between finding and not finding the imported package #46396

ilogico opened this issue Oct 16, 2021 · 1 comment · Fixed by #46818
Assignees
@weswigham
Labels
Bug A bug in TypeScript Fix Available A PR has been opened for this issue
Milestone
TypeScript 4.6.0

Comments

@ilogico
Copy link

ilogico commented Oct 16, 2021 •
edited
Loading

Bug Report

🔎 Search Terms

  • node12
  • nodenext

🕗 Version & Regression Information

4.5.0-dev.20211016

  • I was unable to test this on prior versions because this nodenext modules will only become available in 4.5

💻 Code

It needs a monorepo setup to reproduce. I made a small repository: https://github.com/ilogico/ts-nodenext-bug

This happens all the time when editing a file, but it's hard to reproduce in a deterministic way.

I reproduce it here by toggling line comments back and forth:
bug

🙁 Actual behavior

The language service says it cannot find the module or it's corresponding type declarations after having correctly resolved the module.

🙂 Expected behavior

The module stays resolved.
@DanielRosenwasser DanielRosenwasser mentioned this issue Oct 18, 2021
Closed
@DanielRosenwasser
Copy link
Member

I think I observed something similar at #46373.

@DanielRosenwasser DanielRosenwasser mentioned this issue Oct 20, 2021
Closed
@andrewbranch andrewbranch mentioned this issue Nov 11, 2021
Closed
@andrewbranch andrewbranch added the Bug A bug in TypeScript label Nov 11, 2021
@andrewbranch andrewbranch added this to the TypeScript 4.6.0 milestone Nov 11, 2021
@andrewbranch andrewbranch mentioned this issue Nov 16, 2021
Merged
@typescript-bot typescript-bot added the Fix Available A PR has been opened for this issue label Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@weswigham weswigham

Labels
Bug A bug in TypeScript Fix Available A PR has been opened for this issue
Projects
None yet
Milestone
TypeScript 4.6.0
Development

Successfully merging a pull request may close this issue.

Fix broken module resolution after large/rapid edits in nodenext andrewbranch/TypeScript
5 participants
@DanielRosenwasser @ilogico @weswigham @andrewbranch @typescript-bot