Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redo package size changes checks in CI #53153

Closed
jakebailey opened this issue Mar 7, 2023 · 0 comments · Fixed by #53241
Closed

Redo package size changes checks in CI #53153

jakebailey opened this issue Mar 7, 2023 · 0 comments · Fixed by #53241
Assignees
Labels
Infrastructure Issue relates to TypeScript team infrastructure

Comments

@jakebailey
Copy link
Member

jakebailey commented Mar 7, 2023

We used to get this via the LKG task.

After #52226, LKG no longer exists. To ensure that we can still get some idea of when we accidentally regress package size too much, I had to add some hacks to the smoke test in CI which builds LKG at main, saves it outside the tree, then switches back to the PR and copies lib back, as though it were there. Then our old package size checks can kick in.

This is a hack and just temporary. What we should actually do is introduce a new CI task which checks this explicitly, then eliminate size checks from our LKG task itself.

The best thing would be to create some failure threshold in CI (right now, 10%?), that fails the build. But, using GitHub's checks API, we could feasibly also output a markdown report into the UI to look at. (This is where I'd like to stick perf results and other changes in the future.)

I've looked at the existing actions in the marketplace, and none really do what we want, in that they all reply via a comment, which will be noisy. Not sure what to do about that, besides writing a whole new action from scratch. Maybe that's fine, because there are other actions I'd like to write too (e.g. the errors delta repo could be an action that runs on every PR, as could DT and perf).

See also #53123.

@jakebailey jakebailey added the Infrastructure Issue relates to TypeScript team infrastructure label Mar 7, 2023
@jakebailey jakebailey self-assigned this Mar 7, 2023
@jakebailey jakebailey changed the title Check package size changes in CI Redo package size changes in CI Mar 7, 2023
@jakebailey jakebailey changed the title Redo package size changes in CI Redo package size changes checks in CI Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Issue relates to TypeScript team infrastructure
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant