Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VS Debugger broken with certain WebPack generated sourcemaps/bundles #8414

Closed
henrify opened this issue May 1, 2016 · 10 comments
Closed

VS Debugger broken with certain WebPack generated sourcemaps/bundles #8414

henrify opened this issue May 1, 2016 · 10 comments
Assignees
Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue

Comments

@henrify
Copy link

henrify commented May 1, 2016

Visual Studio 2013.5 and 2015.2 debugger doesn't work if bundle and sourcemap is generated with WebPack AND 'when' -library is included in the bundle. Debugging with anything else than VS works.

The original issue with full details and a ready to run repro solution is here: cujojs/when#486

Would be great if you could at least determine why exactly Visual Studio debugger doesn't accept this sourcemap.

@henrify henrify changed the title Debugger broken with certain WebPack generated sourcemaps/bundles VS Debugger broken with certain WebPack generated sourcemaps/bundles May 1, 2016
@mhegazy
Copy link
Contributor

mhegazy commented May 3, 2016

can you provide more details? a sample project would be great too.

@mhegazy
Copy link
Contributor

mhegazy commented May 3, 2016

//CC @sheetalkamat

@mhegazy mhegazy added the Needs More Info The issue still hasn't been fully clarified label May 3, 2016
@henrify
Copy link
Author

henrify commented May 3, 2016

@mhegazy hi, as mentioned, full repro solution as .zip and all details are in this issue: cujojs/when#486

@mhegazy mhegazy added this to the TypeScript 2.0 milestone May 4, 2016
@mhegazy mhegazy added Bug A bug in TypeScript and removed Needs More Info The issue still hasn't been fully clarified labels May 4, 2016
@sheetalkamat
Copy link
Member

@henrify I looked into the sourcemap and it seems the sourcemap contains sourcename as
"file://ignored C:\\Users\\shkamat\\Desktop\\WebpackWhenSourcemapTest\\WebpackWhenSourcemapTest\\WebpackWhenSourcemapTest\\node_modules\\when\\lib vertx"
Which is resulting in the error message in output window as
Error decoding sourcemap contents

The url in the source contents is not a valid URL which is why decoder fails to go ahead further with it.

@henrify
Copy link
Author

henrify commented May 5, 2016

@sheetalkamat yes as discussed in the linked issue, I noticed that too, and built a custom version of the 'When' library which doesn't have that entry at all, but it still fails to debug.

Do you see anything else wrong in the sourcemap?

@henrify
Copy link
Author

henrify commented May 5, 2016

@sheetalkamat i made a ready to run repro solution for you.

This has pre-installed the custom built 'When' NPM module which eliminates the problem URL. Just run 'webpack' on the project's directory and then try to debug in VS.

WebpackWhenSourcemapTest.zip

@sheetalkamat
Copy link
Member

sheetalkamat commented May 5, 2016

@henrify Looking into it , will shortly let you know whats going on.

Update: I am not able to open the zip file as it says it is invalid.

@sheetalkamat
Copy link
Member

@henrify , I haven't heard from you but I have made change in debugger to load files with invalid url syntax if they have inline source.With that change I am able to load your project correctly and hit breakpoints. New version of debugger should fix this for you.

@sheetalkamat sheetalkamat added the Fixed A PR has been merged for this issue label May 19, 2016
@henrify
Copy link
Author

henrify commented May 20, 2016

@sheetalkamat Ups sorry, I had missed your comment about the broken zip.

There must be more to the story than just the invalid url syntax though, as the (broken) zip with custom build of 'When' library without the invalid syntax stuff still didn't work..

@henrify
Copy link
Author

henrify commented May 20, 2016

@sheetalkamat So it appears that GitHub does not send notification when you edit a message, and thus I never got the 'Update I'm not able to open...' part.

I assume that you don't need retry of the broken zip, if my project from the linked issue is anyway working on your computer after the latest changes to debugger?

Anyway, thanks for your help on this issue, and I look forward to having a working debugger again :)

@mhegazy mhegazy closed this as completed Jun 6, 2016
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue
Projects
None yet
Development

No branches or pull requests

3 participants