Reflect control flow effects of optional chains in equality checks #33821
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR we properly reflect control flow effects of optional chains in equality checks. Specifically, when compiling with
--strictNullChecks
,o?.foo === value
, where the type ofvalue
doesn't includeundefined
, we removeundefined
andnull
from the type ofo
in the true branch, ando?.foo == value
, where the type ofvalue
doesn't includeundefined
ornull
, we removeundefined
andnull
from the type ofo
in the true branch, ando?.foo !== undefined
,o?.foo != undefined
oro?.foo != null
we removeundefined
andnull
from the type ofo
in the true branch, andtypeof o?.foo === "xxx"
ortypeof o?.foo == "xxx"
we removeundefined
andnull
from the type ofo
in the true branch, ando?.foo instanceof xxx
we removeundefined
andnull
from the type ofo
in the true branch.Some examples:
Fixes #33806.