More optional chaining control flow analysis #34597
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR we expand on #33821 to reflect more effects of optional chaining in control flow analysis. Some examples:
The complete list of optional chaining constructs with control flow effects in
--strictNullChecks
mode is now:o?.foo === value
, where the type ofvalue
doesn't includeundefined
, we removeundefined
andnull
from the type ofo
in the true branch, ando?.foo !== value
, where the type ofvalue
doesn't includeundefined
, we removeundefined
andnull
from the type ofo
in the false branch, ando?.foo == value
, where the type ofvalue
doesn't includeundefined
ornull
, we removeundefined
andnull
from the type ofo
in the true branch, ando?.foo != value
, where the type ofvalue
doesn't includeundefined
ornull
, we removeundefined
andnull
from the type ofo
in the false branch, ando?.foo === undefined
,o?.foo == undefined
oro?.foo == null
we removeundefined
andnull
from the type ofo
in the false branch, ando?.foo !== undefined
,o?.foo != undefined
oro?.foo != null
we removeundefined
andnull
from the type ofo
in the true branch, andtypeof o?.foo === "xxx"
ortypeof o?.foo == "xxx"
, where"xxx"
is not"undefined"
, we removeundefined
andnull
from the type ofo
in the true branch, andtypeof o?.foo !== "xxx"
ortypeof o?.foo != "xxx"
, where"xxx"
is not"undefined"
, we removeundefined
andnull
from the type ofo
in the false branch, andtypeof o?.foo === "undefined"
ortypeof o?.foo == "undefined"
we removeundefined
andnull
from the type ofo
in the false branch, andtypeof o?.foo !== "undefined"
ortypeof o?.foo != "undefined"
we removeundefined
andnull
from the type ofo
in the true branch, ando?.foo instanceof xxx
we removeundefined
andnull
from the type ofo
in the true branch, andcase xxx
block of aswitch (o?.foo)
statement we removeundefined
andnull
from the type ofo
provided the type ofxxx
doesn't includeundefined
, andcase xxx
block of aswitch (typeof o?.foo)
statement we removeundefined
andnull
from the type ofo
providedxxx
isn't"undefined"
, andassertIsXXX(o?.foo)
, whereassertIsXXX
is declared with anasserts x is XXX
type predicate and typeXXX
doesn't includeundefined
, we removeundefined
andnull
from the type ofo
, andassert(xxx)
, whereassert
is declared with anasserts x
type predicate, we reflect the false branch effects of the logical expressionxxx
, including effects from optional property access chains.Fixes #34570.