Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert cloneNode overrides in the DOM #37568

Merged
merged 2 commits into from
Mar 25, 2020
Merged

Conversation

sandersn
Copy link
Member

@sandersn
Copy link
Member Author

@typescript-bot cherry-pick this to release-3.9 and LKG ?

@typescript-bot
Copy link
Collaborator

typescript-bot commented Mar 25, 2020

Heya @sandersn, I've started to run the task to cherry-pick this into release-3.9 on this PR at f5d9c9c. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

Hey @sandersn, I've opened #37569 for you.

typescript-bot pushed a commit to typescript-bot/TypeScript that referenced this pull request Mar 25, 2020
Component commits:
f5d9c9c Revert cloneNode overrides in the DOM
See microsoft/TypeScript-DOM-lib-generator#842
@sandersn
Copy link
Member Author

@typescript-bot cherry-pick this to release-3.9 and LKG

@typescript-bot
Copy link
Collaborator

typescript-bot commented Mar 25, 2020

Heya @sandersn, I've started to run the task to cherry-pick this into release-3.9 on this PR at ace6d68. You can monitor the build here.

@sandersn sandersn merged commit a1c8608 into master Mar 25, 2020
@sandersn sandersn deleted the revert-cloneNode-overrides branch March 25, 2020 00:56
@typescript-bot
Copy link
Collaborator

Hey @sandersn, I couldn't open a PR with the cherry-pick. (You can check the log here). You may need to squash and pick this PR into release-3.9 manually.

typescript-bot pushed a commit to typescript-bot/TypeScript that referenced this pull request Mar 25, 2020
Component commits:
f5d9c9c Revert cloneNode overrides in the DOM
See microsoft/TypeScript-DOM-lib-generator#842

ace6d68 update baselines
DanielRosenwasser pushed a commit that referenced this pull request Mar 25, 2020
* Cherry-pick PR #37568 into release-3.9

Component commits:
f5d9c9c Revert cloneNode overrides in the DOM
See microsoft/TypeScript-DOM-lib-generator#842

ace6d68 update baselines

* Update LKG

Co-authored-by: Nathan Shively-Sanders <nathansa@microsoft.com>
Co-authored-by: typescript-bot <typescript@microsoft.com>
@IllusionMH
Copy link
Contributor

Should #283 be reopened then with more info?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants