-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert cloneNode overrides in the DOM #37568
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@typescript-bot cherry-pick this to release-3.9 and LKG ? |
typescript-bot
pushed a commit
to typescript-bot/TypeScript
that referenced
this pull request
Mar 25, 2020
Component commits: f5d9c9c Revert cloneNode overrides in the DOM See microsoft/TypeScript-DOM-lib-generator#842
@typescript-bot cherry-pick this to release-3.9 and LKG |
Hey @sandersn, I couldn't open a PR with the cherry-pick. (You can check the log here). You may need to squash and pick this PR into release-3.9 manually. |
typescript-bot
pushed a commit
to typescript-bot/TypeScript
that referenced
this pull request
Mar 25, 2020
Component commits: f5d9c9c Revert cloneNode overrides in the DOM See microsoft/TypeScript-DOM-lib-generator#842 ace6d68 update baselines
DanielRosenwasser
pushed a commit
that referenced
this pull request
Mar 25, 2020
* Cherry-pick PR #37568 into release-3.9 Component commits: f5d9c9c Revert cloneNode overrides in the DOM See microsoft/TypeScript-DOM-lib-generator#842 ace6d68 update baselines * Update LKG Co-authored-by: Nathan Shively-Sanders <nathansa@microsoft.com> Co-authored-by: typescript-bot <typescript@microsoft.com>
Should #283 be reopened then with more info? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See microsoft/TypeScript-DOM-lib-generator#842