Fix relative path #57961
Fix relative path #57961
Conversation
typescript-bot
added
the
For Uncommitted Bug
| const nearestTargetPackageJson = getNearestAncestorDirectoryWithPackageJson(host, getDirectoryPath(modulePath), { returnAsBooleanIfHostMethodMissing: true }); | ||
| const nearestSourcePackageJson = getNearestAncestorDirectoryWithPackageJson(host, sourceDirectory, { returnAsBooleanIfHostMethodMissing: true }); |
There was a problem hiding this comment.
Why not just do !! at the start of these? No other calls need to pass these options in.
There was a problem hiding this comment.
Why not just do
!!at the start of these? No other calls need to pass these options in.
According to the logic before, if the host.getNearestAncestorDirectoryWithPackageJson methods exist, will use the return value of a string
There was a problem hiding this comment.
I see, didn't realize this returned a string, and the point is to compare those.
I don't think that this is exactly how we'd want to fix it as it seems to overfit for the bug, but without a test case I can't really offer a better idea yet.
There was a problem hiding this comment.
I'll say that this fix just seems confusing; it's basically changing the code to report maybeNonRelative if the paths have differing "is in a package"-ness, but that sure feels like the wrong signal. But that's what the old code kinda did too. @andrewbranch may have a better clue here.
There was a problem hiding this comment.
Wouldn't you just be able to check that getNearestAncestorDirectoryWithPackageJson(host, sourceDirectory) !== undefined?
|
FWIW you'll want to pull out a test for this; since you made a minimal repro in #57956 you should be able to construct a test case in |
Fixes #57956
Fixes #57926
Related changes: fbcdb8c#r140302331