Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diagnose logs incorrect cache server url #289

Closed
jrbriggs opened this issue Sep 21, 2018 · 2 comments
Closed

Diagnose logs incorrect cache server url #289

jrbriggs opened this issue Sep 21, 2018 · 2 comments
Assignees

Comments

@jrbriggs
Copy link
Member

Steps to reproduce:

  1. Have a cache server.
  2. Run gvfs diagnose.
  3. Look in diagnostics.log

Expected Behavior:

  1. Should have correct cache server url.

Instead shows invalid://repoUrl.

@derrickstolee
Copy link
Contributor

This also affects jobs like gvfs repair and can even lead to the URL being passed to a credential manager.

@jrbriggs jrbriggs assigned jeschu1 and unassigned alameenshah Oct 1, 2018
@jeschu1
Copy link
Member

jeschu1 commented Oct 3, 2018

There are 2 different bugs here

  1. Under certain conditions we don't correctly init the enlistment on repair, causing us to use an invalid url. This is do to a miss on refactoring.
  2. If we don't have a cache server we are showing an invalid url instead of nothing. This is due to us using the default url since it wasn't overwritten on the config lookup.

I will addresss each in separate PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants