Patch fails on renaming file with "Invalid argument"

[mikewl]

While compiling some software, anything that used patch and renamed a file gave this error. This breaks compilation for many projects.

[ghost]

Can you give an example?

[mikewl]

Attempting to compile Julia fails when patch is invoked on DSFMT. It is attempting to rename a .h file to .h.orig.
I checked my vm and it definitely is working on a clean build still, this is isolated to bash on Windows.

On 11 Apr 2016, at 08:50, Adam Baxter notifications@github.com wrote:

Can you give an example?

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub

[tkelman]

Here's the exact steps:

curl -O http://www.math.sci.hiroshima-u.ac.jp/~m-mat/MT/SFMT/dSFMT-src-2.2.3.tar.gz
tar -xf dSFMT-src-2.2.3.tar.gz
cd dSFMT-src-2.2.3
curl https://raw.githubusercontent.com/JuliaLang/julia/v0.4.5/deps/dSFMT.h.patch | patch

Works fine in Cygwin, actual Ubuntu, etc.

[tkelman]

strace output: https://gist.github.com/263edd6d13cd28d279f42b676a05f908

Missing renameat maybe? http://git.savannah.gnu.org/cgit/patch.git/tree/src/safe.c#n589

[hut8]

I think this might be the same. Sorry for the duplicate if it is. Mine doesn't use renameat

#163

[benhillis]

Thanks for the information everyone. I've implemented the renameat system call and can verify that patch is now working in our dev branch. The fix will be making its way to the flighting branch (no firm ETA).

[davidanthoff]

Great! I assume the flighting branch is different from the fast insider ring? I.e. this won't be in the fast ring build released today?

[benhillis]

Correct, this will not be in the build that is being released today since it was just checked into our development branch yesterday. All rings (fast, slow, release preview) get their builds out of the flighting branch but with different release criteria. There's a good table on Wikipedia with more info.

We will be releasing some release notes soon on what's fixed in the build that is being released today.

[HenkPoley]

Probably known, but.. this is still a bug on build 14332: ocaml/opam-repository#6343 (comment)

[benhillis]

Yeah the fix for this didn't make it to the most recent flight, it's still inbound (implementing the renameat system call). Keep an eye out for the release notes of a future flight.

[HenkPoley]

The bug I was hitting with opam install sha.1.9 (that uses patch somewhere) is resolved in Windows 10 build 14342. There are no relevant changes to their package, so this must be resolved outside of the changelog.

[benhillis]

Good to hear! FYI - The fix for patch was implementing the renameat system call. I'll make sure the release notes for the new build are posted today.

[tkelman]

The originally reported issue works for me as well in 14342, so I think you can close this. If you try to build Julia you'll hit #272, but that's unrelated.