Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text clipping path regression #1501

Closed
edvv opened this issue Dec 2, 2016 · 7 comments
Closed

Text clipping path regression #1501

edvv opened this issue Dec 2, 2016 · 7 comments

Comments

@edvv
Copy link

edvv commented Dec 2, 2016

Dear WinObjC Engineers,

From release 41 to 42 there is a regression in text clipping path. Release 41 properly truncated text at the clipping path boundary while release 42 text does not clip at the clipping path.

Sincerely,

Ed

@edvv
Copy link
Author

edvv commented Dec 6, 2016

This problem persists with release 43.

@DHowett-MSFT
Copy link

Hi @edvv! Thanks for the report.

Just to make sure, you're talking about the combination of CGContext(EO)?Clip and the CT+CG glyph/frame/line drawing APIs, correct?

If so, we're mirroring most of the Cairo context's state into the text renderer and we appear to have missed the clipping/masking parameters.

@edvv
Copy link
Author

edvv commented Dec 7, 2016

@DHowett-MSFT That is correct.

@rajsesh rajsesh added Task and removed Bug labels Dec 15, 2016
@rajsesh rajsesh added this to the 1701 milestone Dec 15, 2016
@ArnOmsft ArnOmsft modified the milestones: 1701, 1702 Dec 16, 2016
@ArnOmsft
Copy link
Member

@edvv, fixing this requires the work we're doing to implement CoreGraphics on D2D (cf. the CGD2D branch) to be merged to master. We're planning to merge at the end of January (that's our 1701 sprint) so the fix for this specific issue will come in February (our 1702 sprint).

@edvv
Copy link
Author

edvv commented Dec 16, 2016

@ArnOmsft That sounds very sensible. Thank you for the consideration.

@DHowett-MSFT
Copy link

This is fixed in develop with the merge of #1892.

@edvv
Copy link
Author

edvv commented Feb 1, 2017

@DHowett-MSFT I am very excited to try this out in the next release. Thank you for the note and fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants