Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page navigation from search should expand TreeView and select page #420

Closed
2 of 13 tasks
michael-hawker opened this issue May 6, 2020 · 2 comments · Fixed by #478
Closed
2 of 13 tasks

Page navigation from search should expand TreeView and select page #420

michael-hawker opened this issue May 6, 2020 · 2 comments · Fixed by #478

Comments

@michael-hawker
Copy link
Contributor

Describe the bug
When you search for a page like ItemsRepeater in the sample app you're taken directly to the page, but you have no idea where that page exists in the navigation tree. It would help with the discovery of similar controls if they page is brought forth as the selected/opened page in the NavigationView.

Steps to reproduce the bug

  1. Go to Sample App
  2. Search for a control in the search box
  3. Select a choice to navigate to that page from the dropdown

Expected behavior
Page selected in NavigationView.

Actual behavior
No indication of which page I'm viewing in hierarchy.

Screenshots

image

image

Version Info

Gallery version (found on Settings page):
1.2.15.0

Windows 10 version:

  • Insider Build (19624)
  • November 2019 Update (18363)
  • May 2019 Update (18362)
  • October 2018 Update (17763)
  • April 2018 Update (17134)
  • Fall Creators Update (16299)
  • Creators Update (15063)
  • Anniversary Update (14393)

Device form factor:

  • Desktop
  • Mobile
  • Xbox
  • Surface Hub
  • IoT

Additional context

@gregwoo-microsoft
Copy link
Contributor

@chingucoding do you know if your solution (PR #478) can be applied to the two issues mentioned above?

@marcelwgn
Copy link
Collaborator

#613 is partially fixed (the selection indicator is missing), #726 is not fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants