From 1c784c0beec87bbd62d3dd53b708c63b614758e4 Mon Sep 17 00:00:00 2001 From: Scott Jones Date: Fri, 1 Sep 2023 09:31:00 -0700 Subject: [PATCH 1/3] Restore WAP solution and project for bundle publishing (and remove win32) --- .../WinUIGallery.DesktopWap.Package.wapproj | 103 ++++++++++++++++++ WinUIGallery/WinUIGallery.DesktopWap.sln | 62 +++++++++++ WinUIGallery/WinUIGallery.sln | 14 --- 3 files changed, 165 insertions(+), 14 deletions(-) create mode 100644 WinUIGallery/WinUIGallery.DesktopWap.Package.wapproj create mode 100644 WinUIGallery/WinUIGallery.DesktopWap.sln diff --git a/WinUIGallery/WinUIGallery.DesktopWap.Package.wapproj b/WinUIGallery/WinUIGallery.DesktopWap.Package.wapproj new file mode 100644 index 000000000..33f3ec364 --- /dev/null +++ b/WinUIGallery/WinUIGallery.DesktopWap.Package.wapproj @@ -0,0 +1,103 @@ + + + + 15.0 + + + + Debug + x86 + + + Release + x86 + + + Debug + x64 + + + Release + x64 + + + Debug + ARM64 + + + Release + ARM64 + + + + $(MSBuildExtensionsPath)\Microsoft\DesktopBridge\ + Windows + 10.0 + + + + + 4c7b20d7-5f5c-440e-8da3-b19a328cc8bd + 10.0.19041.0 + 10.0.17763.0 + en-US + True + WinUIGallery.csproj + WinUIGallery.DesktopWap + + + $(ProjectRoot)build\MSTest.pfx + + + False + SHA256 + False + True + x86|x64|arm64 + x86|x64|ARM64 + 0 + net5.0-windows$(TargetPlatformVersion);net6.0-windows$(TargetPlatformVersion);$(AssetTargetFallback) + D:\git\WinUI-Gallery2\build\WinUI-Gallery-Test.pfx + + + Always + + + Always + + + Always + + + Always + + + Always + + + Always + + + + Designer + + + Designer + + + + + True + Properties\PublishProfiles\win10-$(Platform)-unpackaged.pubxml + + + + + build + + + build + + + + \ No newline at end of file diff --git a/WinUIGallery/WinUIGallery.DesktopWap.sln b/WinUIGallery/WinUIGallery.DesktopWap.sln new file mode 100644 index 000000000..e6841b1e5 --- /dev/null +++ b/WinUIGallery/WinUIGallery.DesktopWap.sln @@ -0,0 +1,62 @@ + +Microsoft Visual Studio Solution File, Format Version 12.00 +# Visual Studio Version 17 +VisualStudioVersion = 17.1.32319.34 +MinimumVisualStudioVersion = 10.0.40219.1 +Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Solution Items", "Solution Items", "{A98961E3-CB85-4AFC-990C-FD9F57043E7D}" + ProjectSection(SolutionItems) = preProject + ..\Directory.Build.props = ..\Directory.Build.props + EndProjectSection +EndProject +Project("{C7167F0D-BC9F-4E6E-AFE1-012C56B48DB5}") = "WinUIGallery.DesktopWap.Package", "WinUIGallery.DesktopWap.Package.wapproj", "{4C7B20D7-5F5C-440E-8DA3-B19A328CC8BD}" +EndProject +Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "WinUIGallery", "WinUIGallery.csproj", "{D78F3B56-340D-44F0-9AF1-320D473BA611}" +EndProject +Global + GlobalSection(SolutionConfigurationPlatforms) = preSolution + Debug|ARM64 = Debug|ARM64 + Debug|x64 = Debug|x64 + Debug|x86 = Debug|x86 + Release|ARM64 = Release|ARM64 + Release|x64 = Release|x64 + Release|x86 = Release|x86 + EndGlobalSection + GlobalSection(ProjectConfigurationPlatforms) = postSolution + {4C7B20D7-5F5C-440E-8DA3-B19A328CC8BD}.Debug|ARM64.ActiveCfg = Debug|ARM64 + {4C7B20D7-5F5C-440E-8DA3-B19A328CC8BD}.Debug|ARM64.Build.0 = Debug|ARM64 + {4C7B20D7-5F5C-440E-8DA3-B19A328CC8BD}.Debug|ARM64.Deploy.0 = Debug|ARM64 + {4C7B20D7-5F5C-440E-8DA3-B19A328CC8BD}.Debug|x64.ActiveCfg = Debug|x64 + {4C7B20D7-5F5C-440E-8DA3-B19A328CC8BD}.Debug|x64.Build.0 = Debug|x64 + {4C7B20D7-5F5C-440E-8DA3-B19A328CC8BD}.Debug|x64.Deploy.0 = Debug|x64 + {4C7B20D7-5F5C-440E-8DA3-B19A328CC8BD}.Debug|x86.ActiveCfg = Debug|x86 + {4C7B20D7-5F5C-440E-8DA3-B19A328CC8BD}.Debug|x86.Build.0 = Debug|x86 + {4C7B20D7-5F5C-440E-8DA3-B19A328CC8BD}.Debug|x86.Deploy.0 = Debug|x86 + {4C7B20D7-5F5C-440E-8DA3-B19A328CC8BD}.Release|ARM64.ActiveCfg = Release|ARM64 + {4C7B20D7-5F5C-440E-8DA3-B19A328CC8BD}.Release|ARM64.Build.0 = Release|ARM64 + {4C7B20D7-5F5C-440E-8DA3-B19A328CC8BD}.Release|ARM64.Deploy.0 = Release|ARM64 + {4C7B20D7-5F5C-440E-8DA3-B19A328CC8BD}.Release|x64.ActiveCfg = Release|x64 + {4C7B20D7-5F5C-440E-8DA3-B19A328CC8BD}.Release|x64.Build.0 = Release|x64 + {4C7B20D7-5F5C-440E-8DA3-B19A328CC8BD}.Release|x64.Deploy.0 = Release|x64 + {4C7B20D7-5F5C-440E-8DA3-B19A328CC8BD}.Release|x86.ActiveCfg = Release|x86 + {4C7B20D7-5F5C-440E-8DA3-B19A328CC8BD}.Release|x86.Build.0 = Release|x86 + {4C7B20D7-5F5C-440E-8DA3-B19A328CC8BD}.Release|x86.Deploy.0 = Release|x86 + {D78F3B56-340D-44F0-9AF1-320D473BA611}.Debug|ARM64.ActiveCfg = Debug-Unpackaged|ARM64 + {D78F3B56-340D-44F0-9AF1-320D473BA611}.Debug|ARM64.Build.0 = Debug-Unpackaged|ARM64 + {D78F3B56-340D-44F0-9AF1-320D473BA611}.Debug|x64.ActiveCfg = Debug-Unpackaged|x64 + {D78F3B56-340D-44F0-9AF1-320D473BA611}.Debug|x64.Build.0 = Debug-Unpackaged|x64 + {D78F3B56-340D-44F0-9AF1-320D473BA611}.Debug|x86.ActiveCfg = Debug-Unpackaged|x86 + {D78F3B56-340D-44F0-9AF1-320D473BA611}.Debug|x86.Build.0 = Debug-Unpackaged|x86 + {D78F3B56-340D-44F0-9AF1-320D473BA611}.Release|ARM64.ActiveCfg = Release-Unpackaged|ARM64 + {D78F3B56-340D-44F0-9AF1-320D473BA611}.Release|ARM64.Build.0 = Release-Unpackaged|ARM64 + {D78F3B56-340D-44F0-9AF1-320D473BA611}.Release|x64.ActiveCfg = Release-Unpackaged|x64 + {D78F3B56-340D-44F0-9AF1-320D473BA611}.Release|x64.Build.0 = Release-Unpackaged|x64 + {D78F3B56-340D-44F0-9AF1-320D473BA611}.Release|x86.ActiveCfg = Release-Unpackaged|x86 + {D78F3B56-340D-44F0-9AF1-320D473BA611}.Release|x86.Build.0 = Release-Unpackaged|x86 + EndGlobalSection + GlobalSection(SolutionProperties) = preSolution + HideSolutionNode = FALSE + EndGlobalSection + GlobalSection(ExtensibilityGlobals) = postSolution + SolutionGuid = {5B033CDA-6491-405C-A05B-CEE6AC4060B9} + EndGlobalSection +EndGlobal diff --git a/WinUIGallery/WinUIGallery.sln b/WinUIGallery/WinUIGallery.sln index 870e4ca6f..ae69389f3 100644 --- a/WinUIGallery/WinUIGallery.sln +++ b/WinUIGallery/WinUIGallery.sln @@ -13,19 +13,15 @@ EndProject Global GlobalSection(SolutionConfigurationPlatforms) = preSolution Debug|ARM64 = Debug|ARM64 - Debug|Win32 = Debug|Win32 Debug|x64 = Debug|x64 Debug|x86 = Debug|x86 Debug-Unpackaged|ARM64 = Debug-Unpackaged|ARM64 - Debug-Unpackaged|Win32 = Debug-Unpackaged|Win32 Debug-Unpackaged|x64 = Debug-Unpackaged|x64 Debug-Unpackaged|x86 = Debug-Unpackaged|x86 Release|ARM64 = Release|ARM64 - Release|Win32 = Release|Win32 Release|x64 = Release|x64 Release|x86 = Release|x86 Release-Unpackaged|ARM64 = Release-Unpackaged|ARM64 - Release-Unpackaged|Win32 = Release-Unpackaged|Win32 Release-Unpackaged|x64 = Release-Unpackaged|x64 Release-Unpackaged|x86 = Release-Unpackaged|x86 EndGlobalSection @@ -33,9 +29,6 @@ Global {D78F3B56-340D-44F0-9AF1-320D473BA611}.Debug|ARM64.ActiveCfg = Debug|ARM64 {D78F3B56-340D-44F0-9AF1-320D473BA611}.Debug|ARM64.Build.0 = Debug|ARM64 {D78F3B56-340D-44F0-9AF1-320D473BA611}.Debug|ARM64.Deploy.0 = Debug|ARM64 - {D78F3B56-340D-44F0-9AF1-320D473BA611}.Debug|Win32.ActiveCfg = Debug|x86 - {D78F3B56-340D-44F0-9AF1-320D473BA611}.Debug|Win32.Build.0 = Debug|x86 - {D78F3B56-340D-44F0-9AF1-320D473BA611}.Debug|Win32.Deploy.0 = Debug|x86 {D78F3B56-340D-44F0-9AF1-320D473BA611}.Debug|x64.ActiveCfg = Debug|x64 {D78F3B56-340D-44F0-9AF1-320D473BA611}.Debug|x64.Build.0 = Debug|x64 {D78F3B56-340D-44F0-9AF1-320D473BA611}.Debug|x64.Deploy.0 = Debug|x64 @@ -44,8 +37,6 @@ Global {D78F3B56-340D-44F0-9AF1-320D473BA611}.Debug|x86.Deploy.0 = Debug|x86 {D78F3B56-340D-44F0-9AF1-320D473BA611}.Debug-Unpackaged|ARM64.ActiveCfg = Debug-Unpackaged|ARM64 {D78F3B56-340D-44F0-9AF1-320D473BA611}.Debug-Unpackaged|ARM64.Build.0 = Debug-Unpackaged|ARM64 - {D78F3B56-340D-44F0-9AF1-320D473BA611}.Debug-Unpackaged|Win32.ActiveCfg = Debug-Unpackaged|x86 - {D78F3B56-340D-44F0-9AF1-320D473BA611}.Debug-Unpackaged|Win32.Build.0 = Debug-Unpackaged|x86 {D78F3B56-340D-44F0-9AF1-320D473BA611}.Debug-Unpackaged|x64.ActiveCfg = Debug-Unpackaged|x64 {D78F3B56-340D-44F0-9AF1-320D473BA611}.Debug-Unpackaged|x64.Build.0 = Debug-Unpackaged|x64 {D78F3B56-340D-44F0-9AF1-320D473BA611}.Debug-Unpackaged|x86.ActiveCfg = Debug-Unpackaged|x86 @@ -53,9 +44,6 @@ Global {D78F3B56-340D-44F0-9AF1-320D473BA611}.Release|ARM64.ActiveCfg = Release|ARM64 {D78F3B56-340D-44F0-9AF1-320D473BA611}.Release|ARM64.Build.0 = Release|ARM64 {D78F3B56-340D-44F0-9AF1-320D473BA611}.Release|ARM64.Deploy.0 = Release|ARM64 - {D78F3B56-340D-44F0-9AF1-320D473BA611}.Release|Win32.ActiveCfg = Release|x86 - {D78F3B56-340D-44F0-9AF1-320D473BA611}.Release|Win32.Build.0 = Release|x86 - {D78F3B56-340D-44F0-9AF1-320D473BA611}.Release|Win32.Deploy.0 = Release|x86 {D78F3B56-340D-44F0-9AF1-320D473BA611}.Release|x64.ActiveCfg = Release|x64 {D78F3B56-340D-44F0-9AF1-320D473BA611}.Release|x64.Build.0 = Release|x64 {D78F3B56-340D-44F0-9AF1-320D473BA611}.Release|x64.Deploy.0 = Release|x64 @@ -64,8 +52,6 @@ Global {D78F3B56-340D-44F0-9AF1-320D473BA611}.Release|x86.Deploy.0 = Release|x86 {D78F3B56-340D-44F0-9AF1-320D473BA611}.Release-Unpackaged|ARM64.ActiveCfg = Release-Unpackaged|ARM64 {D78F3B56-340D-44F0-9AF1-320D473BA611}.Release-Unpackaged|ARM64.Build.0 = Release-Unpackaged|ARM64 - {D78F3B56-340D-44F0-9AF1-320D473BA611}.Release-Unpackaged|Win32.ActiveCfg = Release-Unpackaged|x86 - {D78F3B56-340D-44F0-9AF1-320D473BA611}.Release-Unpackaged|Win32.Build.0 = Release-Unpackaged|x86 {D78F3B56-340D-44F0-9AF1-320D473BA611}.Release-Unpackaged|x64.ActiveCfg = Release-Unpackaged|x64 {D78F3B56-340D-44F0-9AF1-320D473BA611}.Release-Unpackaged|x64.Build.0 = Release-Unpackaged|x64 {D78F3B56-340D-44F0-9AF1-320D473BA611}.Release-Unpackaged|x86.ActiveCfg = Release-Unpackaged|x86 From 6f8ba6a1f17c0cc020329c7a4003213f7570d270 Mon Sep 17 00:00:00 2001 From: Scott Jones Date: Fri, 1 Sep 2023 16:03:44 -0700 Subject: [PATCH 2/3] PR feedback - use packaged config with a bit of refactoring --- .../WinUIGallery.DesktopWap.Package.wapproj | 6 +++-- WinUIGallery/WinUIGallery.DesktopWap.sln | 24 +++++++++---------- WinUIGallery/WinUIGallery.csproj | 21 +++++++++------- 3 files changed, 28 insertions(+), 23 deletions(-) diff --git a/WinUIGallery/WinUIGallery.DesktopWap.Package.wapproj b/WinUIGallery/WinUIGallery.DesktopWap.Package.wapproj index 33f3ec364..09c1142ea 100644 --- a/WinUIGallery/WinUIGallery.DesktopWap.Package.wapproj +++ b/WinUIGallery/WinUIGallery.DesktopWap.Package.wapproj @@ -48,6 +48,9 @@ $(ProjectRoot)build\MSTest.pfx + + $(SolutionDir)..\build\WinUI-Gallery-Test.pfx + False SHA256 @@ -57,7 +60,6 @@ x86|x64|ARM64 0 net5.0-windows$(TargetPlatformVersion);net6.0-windows$(TargetPlatformVersion);$(AssetTargetFallback) - D:\git\WinUI-Gallery2\build\WinUI-Gallery-Test.pfx Always @@ -88,7 +90,7 @@ True - Properties\PublishProfiles\win10-$(Platform)-unpackaged.pubxml + Properties\PublishProfiles\win10-$(Platform).pubxml diff --git a/WinUIGallery/WinUIGallery.DesktopWap.sln b/WinUIGallery/WinUIGallery.DesktopWap.sln index e6841b1e5..e687830bb 100644 --- a/WinUIGallery/WinUIGallery.DesktopWap.sln +++ b/WinUIGallery/WinUIGallery.DesktopWap.sln @@ -40,18 +40,18 @@ Global {4C7B20D7-5F5C-440E-8DA3-B19A328CC8BD}.Release|x86.ActiveCfg = Release|x86 {4C7B20D7-5F5C-440E-8DA3-B19A328CC8BD}.Release|x86.Build.0 = Release|x86 {4C7B20D7-5F5C-440E-8DA3-B19A328CC8BD}.Release|x86.Deploy.0 = Release|x86 - {D78F3B56-340D-44F0-9AF1-320D473BA611}.Debug|ARM64.ActiveCfg = Debug-Unpackaged|ARM64 - {D78F3B56-340D-44F0-9AF1-320D473BA611}.Debug|ARM64.Build.0 = Debug-Unpackaged|ARM64 - {D78F3B56-340D-44F0-9AF1-320D473BA611}.Debug|x64.ActiveCfg = Debug-Unpackaged|x64 - {D78F3B56-340D-44F0-9AF1-320D473BA611}.Debug|x64.Build.0 = Debug-Unpackaged|x64 - {D78F3B56-340D-44F0-9AF1-320D473BA611}.Debug|x86.ActiveCfg = Debug-Unpackaged|x86 - {D78F3B56-340D-44F0-9AF1-320D473BA611}.Debug|x86.Build.0 = Debug-Unpackaged|x86 - {D78F3B56-340D-44F0-9AF1-320D473BA611}.Release|ARM64.ActiveCfg = Release-Unpackaged|ARM64 - {D78F3B56-340D-44F0-9AF1-320D473BA611}.Release|ARM64.Build.0 = Release-Unpackaged|ARM64 - {D78F3B56-340D-44F0-9AF1-320D473BA611}.Release|x64.ActiveCfg = Release-Unpackaged|x64 - {D78F3B56-340D-44F0-9AF1-320D473BA611}.Release|x64.Build.0 = Release-Unpackaged|x64 - {D78F3B56-340D-44F0-9AF1-320D473BA611}.Release|x86.ActiveCfg = Release-Unpackaged|x86 - {D78F3B56-340D-44F0-9AF1-320D473BA611}.Release|x86.Build.0 = Release-Unpackaged|x86 + {D78F3B56-340D-44F0-9AF1-320D473BA611}.Debug|ARM64.ActiveCfg = Debug|ARM64 + {D78F3B56-340D-44F0-9AF1-320D473BA611}.Debug|ARM64.Build.0 = Debug|ARM64 + {D78F3B56-340D-44F0-9AF1-320D473BA611}.Debug|x64.ActiveCfg = Debug|x64 + {D78F3B56-340D-44F0-9AF1-320D473BA611}.Debug|x64.Build.0 = Debug|x64 + {D78F3B56-340D-44F0-9AF1-320D473BA611}.Debug|x86.ActiveCfg = Debug|x86 + {D78F3B56-340D-44F0-9AF1-320D473BA611}.Debug|x86.Build.0 = Debug|x86 + {D78F3B56-340D-44F0-9AF1-320D473BA611}.Release|ARM64.ActiveCfg = Release|ARM64 + {D78F3B56-340D-44F0-9AF1-320D473BA611}.Release|ARM64.Build.0 = Release|ARM64 + {D78F3B56-340D-44F0-9AF1-320D473BA611}.Release|x64.ActiveCfg = Release|x64 + {D78F3B56-340D-44F0-9AF1-320D473BA611}.Release|x64.Build.0 = Release|x64 + {D78F3B56-340D-44F0-9AF1-320D473BA611}.Release|x86.ActiveCfg = Release|x86 + {D78F3B56-340D-44F0-9AF1-320D473BA611}.Release|x86.Build.0 = Release|x86 EndGlobalSection GlobalSection(SolutionProperties) = preSolution HideSolutionNode = FALSE diff --git a/WinUIGallery/WinUIGallery.csproj b/WinUIGallery/WinUIGallery.csproj index 9af57bf5a..0ab4b6832 100644 --- a/WinUIGallery/WinUIGallery.csproj +++ b/WinUIGallery/WinUIGallery.csproj @@ -26,16 +26,18 @@ false true false + true + false - + win10-$(Platform)-unpackaged.pubxml false None - + win10-$(Platform).pubxml MSIX WinUIGallery @@ -55,13 +57,10 @@ 0 10.0 $(MSBuildProjectDirectory)\..\build\WinUI-Gallery-Test.pfx + $(PfxFile) - - ..\build\WinUI-Gallery-Test.pfx - - - + Designer @@ -69,6 +68,7 @@ Designer + true @@ -249,12 +249,15 @@ - + + true + + $(CoreCompileDependsOn);GenerateDeploymentManagerCS $(CoreCompileDependsOn);GenerateBootstrapCS - + From 776b8c07135bb9d3724385abc64c01ee1352063b Mon Sep 17 00:00:00 2001 From: Scott Jones Date: Thu, 7 Sep 2023 11:41:03 -0700 Subject: [PATCH 3/3] update WCT to resolve regression --- WinUIGallery/standalone.props | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/WinUIGallery/standalone.props b/WinUIGallery/standalone.props index 143b82309..ab367c245 100644 --- a/WinUIGallery/standalone.props +++ b/WinUIGallery/standalone.props @@ -6,7 +6,7 @@ 6.2.11 1.0.4 2.0.13 - 8.0.230823-rc + 8.0.230907 10.0.22621.756 2.0.3