Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change MiniFilter: Is the PreCreate operation comment correct? #1249

Open
johnwallsmsft opened this issue Jan 10, 2025 · 1 comment
Open
Assignees
Labels

Comments

@johnwallsmsft
Copy link

Is the following comment in the example Change MiniFilter CgPreCreate method correct?

//
// Return FLT_PREOP_SYNCHRONIZE at PreCreate due to
// some callback of PostCreate may be at DPC level.
// eResource is required at level < DPC.
//

The Microsoft documentation mentions that PostCreate will always be called at PASSIVE_LEVEL - ref.

Also, the Microsoft documentation specifically for FLT_PREOP_SYNCHRONIZE states that PreCreate shouldn't return FLT_PREOP_SYNCHRONIZE, as Create operations are already synchronized - ref.

I see a comment on this method in the past, but it looks to be targeting a different comment - Issue 151.

@v-junyli
Copy link

Hi @microsoft/filter-manager can you help John with this question?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants