Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflicting instructions in FileServerUserGuide.md #212

Closed
zherogerluo opened this issue Dec 20, 2019 · 3 comments
Closed

Conflicting instructions in FileServerUserGuide.md #212

zherogerluo opened this issue Dec 20, 2019 · 3 comments

Comments

@zherogerluo
Copy link

In Section 5.1.2.2.3.4 Create Symbolic Links of TestSuites/FileServer/docs/FileServerUserGuide.md, the second step in creating symlink is self-conflicting. Item 2 should be "Add a Symbolic Link to the SMBBasic folder" instead of "Add a Symbolic Link to the SMBBasic\Sub folder".

@yazeng
Copy link
Member

yazeng commented Dec 20, 2019

Hi,

Thank you for reporting this issue. You’re right. The second step of this section is self-conflicting.
We will fix this soon and notify you in this thread when the fix is pushed to staging branch.

Best Regards,
Yan
Windows Protocol Test Suites Development Team

@yazeng
Copy link
Member

yazeng commented Dec 20, 2019

Hi,

It is fixed in commit b2547f3.

Best Regards,
Yan
Windows Protocol Test Suites Development Team

@zherogerluo
Copy link
Author

This instruction does not seem to match the code behavior. In my actual test, the code is looking for Symboliclink2 instead of Sub/Symboliclink2. Will follow up when I confirm it, close this issue for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants