feat(axe-core-4.7): Bump axe.core version to 4.7.2, exclude aria-roledescription, and promote scrollable-region-focusable #6849
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This PR updates axe-core to its latest version, 4.7.2, from 4.6.3. It also bumps the accessibility-insights-report package version. As part of the axe-core update:
aria-roledescription
rule has been deprecated (False positives when using aria-roledescription dequelabs/axe-core#3649).scrollable-region-focusable
axe-core rule failures have been promoted from "needs review" to "serious" (manually removed from explicit "needs review" but included automatically by axe-core), see fix(scrollable-region-focusable): skip native controls dequelabs/axe-core#3862 and Set scrollable-region-focusable impact to serious dequelabs/axe-core#3939.falsePositiveRemoval
introduced in ed75fda has been removed as the corresponding False positive in aria-required-children "unknown" path for child not in accessibility tree with aria-hidden="true" dequelabs/axe-core#3850 has been resolved.It might be easier to review this PR by commit.
Motivation
Part of Feature 2086120 (internal access required to view).
Pull request checklist
yarn fastpass
yarn test
)<rootDir>/test-results/unit/coverage
fix:
,chore:
,feat(feature-name):
,refactor:
). SeeCONTRIBUTING.md
.