-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2 Factor Authentication does not work #33
Comments
This feature is now available as of version 1.116.0. |
This is great news! However how to use this? |
Hi @zhankezk, I hope we made adding 2FA to a build as easy as possible. It requires you to set up an 'app specific password' and get a 'fastlane session' (which should be easy enough to do on your developer box). These can be added to your Service Endpoint, or you can add them in the fields made when selecting two-step verification. See: https://github.com/Microsoft/app-store-vsts-extension#app-store-release. (PS - Thanks to fastlane for doing the heavy lifting in making this possible.) |
Thanks! I saw the options when I opened the Endpoint setups. However don't see any instructions about 2FA in the github link you sent :-( not sure I am looking at wrong places. And Not sure how to use Deliverfile with the extension? |
Two places to look for documentation beyond the help in the plugin:
FWIW, I agree this is a weakness in our documentation for our plugin. I'll look into fleshing it in. As for Deliverfile, you'll find the option to 'Upload Metadata' when distributing 'Production' builds. If you select that, you'll see there's an option to supply a path to the metadata. (See: https://github.com/fastlane/fastlane/tree/master/deliver#usage) |
Thanks for sharing all the documentations. I was using them already, was just hoping for more information specific to the VSTS extension. I pretty much know how to setup now. But while trying to generate a session using fastlane, keep getting errors... give up for now. Fight another day.. Thanks again! |
@zhankezk, I feel your pain! Fight on! 😄 |
Hey guys, just want to jump on this, I'm trying to use the new 2fa auth in a Release definintion, but no matter if I use username + password or service endpoint, I'm still hanging on the prompt to select a verification device. The documentation on how to create a service endpoint is pretty unclear, but I have created one which is: Is there anything I am missing here? It still asks me to select a device to verify my identity. I am using v116 of the task. |
Hi @duckwaffle, it appears to me that you've configured it correctly. How did you setup your fastlane session? It should look something like: |
Hi @lkillgore thats exactly how I set up the web session. I'm not sure I understand your question, I'm definitely using the same username/password for the web session and the release definition task settings. The only thing I can think of is that the user account is connected to multiple teams, however I would think that this wouldn't stop me from getting past the login of fastlane. |
Hi @lkillgore I just tried again with a clean release environment, a brand new service endpoint, and a brand new web session from fastlane. I even removed my fastlane installation and installed it again via brew (I was using the sudo gem install method previously). The process still hangs with the following output:
|
I have also tried with a different apple id which only has one team against it (I created a new websession and app password), and even tried to switch from a release definition to a build definition. Nothing is working for 2fa. |
Hi @duckwaffle, I'm sorry this isn't working for you. I did some testing on this, and I can't reproduce your error. Does it work on your developer machine? To get the basics set up:
Also, could you tell me which version of fastlane you're using? |
Hi @lkillgore , I did a quick test on the mac, and the pilot upload command works as expected, I even tried again using the the same arguments that the build agent was using which were
Didn't have any issues on the local machine. Checking the log output from the macincloud agent I can see that all the variables should be getting set:
|
Oh, and the version of fastlane on the local machine is 2.30.1 and the macincloud agent is installing the latest version of 2.30.2 when it runs. |
OK, I ran a few more tests matching my test to what you have in your logs here, and the authentication works. Unfortunately, I can't easily test the multiple teams part of this, yet. Could you try something else? Try setting your developer machine up as a build agent: That should help us determine if we're dealing with a code problem or an environmental problem. |
@lkillgore it looks like the issue is with my macincloud agent, I ran the test using my local mac set up as a VSTS agent and it didn't have any issues. I would assume that the issue is that my macincloud agent isn't setting environment variables correctly for the app-password and web session for fastlane to pick up. I'll try raising a support ticket with them. Thanks for all your help! |
My pleasure, @duckwaffle. Could you please keep me updated in the event that it is a bug in our extension or if there is a way that we can work around it? Thanks! |
It is not possible to submit an app with 2-Factor-Authentication.
There is no way to enter the verificatin code. So an app specific password should be used.
The text was updated successfully, but these errors were encountered: