Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Almost all tests fail to check for empty config_lists #1077

Closed
afourney opened this issue Dec 28, 2023 · 1 comment
Closed

[Bug]: Almost all tests fail to check for empty config_lists #1077

afourney opened this issue Dec 28, 2023 · 1 comment
Assignees
@sonichi @rickyloynd-microsoft @yiranwu0
Labels
bug Something isn't working

Comments

@afourney
Copy link
Member

afourney commented Dec 28, 2023 •
edited
Loading

Describe the bug

As seen in #1076 many tests fail to check for valid config_lists, and silently default to GPT-4. Even if we are ok with it using GPT-4, this situation silent failure is suboptimal.

Impacted are tests for RetrieveChat, CompressibleAgent, and GPTAssistant.

Steps to reproduce

No response

Expected Behavior

No response

Screenshots and logs

No response

Additional Information

No response
@afourney afourney added the bug Something isn't working label Dec 28, 2023
@afourney afourney mentioned this issue Dec 28, 2023
Merged
3 tasks
@afourney
Copy link
Member Author

#1082 should now help with this as well.

@afourney afourney changed the title [Bug]: Almost all tests fail to check for empty config_lists rendering tests possibly invalid for anything but GPT-4 [Bug]: Almost all tests fail to check for empty config_lists Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sonichi sonichi

@rickyloynd-microsoft rickyloynd-microsoft

@yiranwu0 yiranwu0

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@afourney @sonichi @rickyloynd-microsoft @yiranwu0