Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Set use_docker to True if unspecified #1103

Closed
sonichi opened this issue Dec 30, 2023 · 1 comment · Fixed by #1147
Closed

[Feature Request]: Set use_docker to True if unspecified #1103

sonichi opened this issue Dec 30, 2023 · 1 comment · Fixed by #1147
Assignees
Labels
code-execution execute generated code docker Issues relating to Docker enhancement New feature or request

Comments

@sonichi
Copy link
Contributor

sonichi commented Dec 30, 2023

Is your feature request related to a problem? Please describe.

Currently we output a warning if use_docker is not specified and docker is not installed. It will be more secure if we set the default value to True.

Describe the solution you'd like

[ ] Change the default value in execute_code to True
[ ] Make sure instructions for using docker is complete and visible (e.g., via a link) in every example (README, docs, notebooks)
[ ] Add a comment that to disable docker use_docker must be explicitly set to False in every example code snippet involving code execution
[ ] Check the sample app to make sure it works after these changes.

Additional context

No response

@sonichi sonichi added enhancement New feature or request code-execution execute generated code docker Issues relating to Docker labels Dec 30, 2023
@olgavrou olgavrou self-assigned this Jan 3, 2024
@r3d91ll
Copy link
Contributor

r3d91ll commented Jan 13, 2024

@sonichi thank you for the invite on Discord. I didn't know this was an open issue. I'm wrote up a more polished version of the tutorial on my LinkedIn. You can also find it on my GitHub. Over the weekend I'll work on reformatting it for a pull request to add to the AutoGen documentation. This tutorial is designed to simplify LLM development and make it more accessible.

If you have the bandwidth give it a once over and let me know if there is anything you want added or explained in more detail

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-execution execute generated code docker Issues relating to Docker enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants