-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Issue]: Improve consistency of doc strings across modules #2048
Comments
Additionally, I think we should settle on Google style docstrings. There is great support for them and they are (in my opinion) the easiest to read. A large amount of the codebase already uses this style too. So it's really just making this fact explicit. |
Agreed. |
Is this issue still open. Can I have the opportunity to work on this issue. |
@sharsha315 Yes, please go ahead. |
Hi @RohitRathore1, a little help here. Please, help me with this above error, I am not able to go on further. |
This was fixed in main by fafc29e, please make sure you've updated to latest |
Thank you for the quick response. It's working now. |
Hi @RohitRathore1, I have submitted the PR. Please, review the PR and provide feedback. Thank you. |
@sharsha315 Thanks for your PR. Please read the CLA & if you are agree with it then you can comment @microsoft-github-policy-service agree in the same PR. |
Describe the issue
Doc strings across all files lack consistency, presumably because different authors are using different conventions (including me). Eg, these are PEP 257 guidelines for multi-line doc strings:
It's easy to spot even the violations of the first para. For example:
RetrieveUserProxyAgent
does not have the first single line.autogen/autogen/agentchat/contrib/retrieve_user_proxy_agent.py
Lines 64 to 76 in ee17f19
initiate_chats
uses extra indents that cause it to not render properly in vscode documentation pop outs.autogen/autogen/agentchat/chat.py
Lines 134 to 143 in ee17f19
cc. @ekzhu @jackgerrits
The text was updated successfully, but these errors were encountered: