New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove "Optional" in GroupChat type hints #2221

Closed

ekzhu opened this issue Mar 31, 2024 · 1 comment · Fixed by #2703

Assignees

Labels

good first issue group chat

Collaborator

ekzhu commented Mar 31, 2024 •

edited

Loading

If None case is not handled then the type hint should not have Optional.

Same with several other parameters in the class. We can have a separate PR to fix those parameters cc @joshkyh @marklysze

Originally posted by @ekzhu in #2199 (comment)

ekzhu added good first issue group chat labels

Contributor

ruiwang commented May 15, 2024

I am happy to work on it if you could assign to me. @ekzhu :)

randombet assigned ruiwang

ruiwang mentioned this issue

Update groupchat.py to remove Optional type hint when they are not ch… #2703

Merged

sonichi closed this as completed in #2703

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment