Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve langchain tool example #265

Closed
gagb opened this issue Oct 17, 2023 · 1 comment
Closed

Improve langchain tool example #265

gagb opened this issue Oct 17, 2023 · 1 comment
Assignees
@ElliotWood
Labels
documentation Improvements or additions to documentation

Comments

@gagb
Copy link
Collaborator

gagb commented Oct 17, 2023

Feedback on the notebook/agentchat_langchain.ipynb

Clarify the path of Test.txt. In my run, I had to place in cwd even when work_dir is set to coding. (Mac with python 3.11)
Spark example requires setting up key differently from circumference example. It would be great if the reader has to set everything in the beginning once. Some paths are hardcoded.
@gagb gagb mentioned this issue Oct 17, 2023
Merged
3 tasks
@sonichi sonichi added the documentation Improvements or additions to documentation label Oct 22, 2023
@sonichi sonichi mentioned this issue Oct 23, 2023
Merged
3 tasks
@gagb
Copy link
Collaborator Author

gagb commented Oct 24, 2023

Closing as duplicate of #373

@gagb gagb closed this as completed Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ElliotWood ElliotWood

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ElliotWood @sonichi @gagb