Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Modified files after cloning main?! #2920

Closed
gagb opened this issue Jun 11, 2024 · 7 comments · Fixed by #2915 or #2935
Closed

[Bug]: Modified files after cloning main?! #2920

gagb opened this issue Jun 11, 2024 · 7 comments · Fixed by #2915 or #2935
Labels
bug Something isn't working

Comments

@gagb
Copy link
Collaborator

gagb commented Jun 11, 2024

Describe the bug

Cloning current autogen's main results in weird behavior...
E.g., create a new code space on autogen main and run git status without making any modifications:
The screenshot below is for code space, but it can happens on wsl and Mac as well.

image

Steps to reproduce

No response

Model Used

No response

Expected Behavior

No response

Screenshots and logs

No response

Additional Information

No response

@gagb gagb added the bug Something isn't working label Jun 11, 2024
@qingyun-wu
Copy link
Contributor

I also see this weird behavior. The two files I see are "test/test_notebook.py" and "website/blog/authors.yml".

@willeppy
Copy link

Also having this issue.

I think it might have to do with the line endings on these files not being correct / matching the prescribed ones in .gitattributes? Maybe VS Code updates the files automatically which is why it shows changes (but none visible in the diff view)

@davorrunje
Copy link
Collaborator

davorrunje commented Jun 12, 2024

The problem is CRLF instead of LF file format, I created a PR to fix it #2915

@gagb
Copy link
Collaborator Author

gagb commented Jun 13, 2024

This is what I saw this morning in a new codespace -- so the issue wasn't fully addressed:

image

@davorrunje
Copy link
Collaborator

@gagb I somehow missed those two files at the first attempt (still not sure how because I used a script for it). Anyhow, here is a new PR #2935

@davorrunje davorrunje mentioned this issue Jun 13, 2024
3 tasks
@davorrunje
Copy link
Collaborator

@davorrunje
Copy link
Collaborator

Screenshot 2024-06-14 at 09 04 07

@gagb just checked, everything seems fine now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants