Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test cases for async function calls #517

Closed
gagb opened this issue Nov 1, 2023 · 0 comments
Closed

Add test cases for async function calls #517

gagb opened this issue Nov 1, 2023 · 0 comments
Assignees
Labels
group chat/teams group-chat-related issues

Comments

@gagb
Copy link
Collaborator

gagb commented Nov 1, 2023

          > > To test I created a sample notebook two agents and a group chat. The notebook worked. I can upload the example to `notebooks/` in a different PR if its useful.

The reason to have tests is to ensure code coverage in CI. Notebooks are good for a different purpose. They can't replace tests unless they are included in the tests.

Sounds good, I will contribute a test case in a different PR (see async-test branch) :) Thanks @victordibia for helping with it.

Originally posted by @gagb in #87 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
group chat/teams group-chat-related issues
Projects
None yet
Development

No branches or pull requests

1 participant