Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testbed - deprecate use of the ENV file, and instead use the environment parameter of container.run() #987

Closed
Tracked by #973
afourney opened this issue Dec 15, 2023 · 1 comment
Assignees

Comments

@afourney
Copy link
Member

afourney commented Dec 15, 2023

In the Testbed, environment variables are handled by populating and ENV file and sharing it with the Docker container via a shared folder. However, we then need to be very sure to delete this file when sharing the results of a run. The current script handles deletion in most cases, but not if Docker times out, or if there is a keyboard interrupt. By passing environment variables through the sanctioned Docker mechanism, we remove the need to manage this file.

@afourney afourney changed the title Deprecate use of the ENV file, and instead use the environment parameter of container.run() Testbed - deprecate use of the ENV file, and instead use the environment parameter of container.run() Dec 15, 2023
@afourney afourney self-assigned this Dec 15, 2023
@afourney afourney mentioned this issue Dec 22, 2023
3 tasks
@afourney
Copy link
Member Author

Completed in #1048

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant