Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Include pipeline data in Approval object in v7 pipeline approvals #147

Open
jeremyrickard opened this issue Jan 2, 2024 · 0 comments

Comments

@jeremyrickard
Copy link

The Approval object in v7/pipelineapprovals doesn't seem to match the actual REST response type.

{
    "id": "16741a55-948b-4194-8c63-1637ca311a46",
    "steps": [],
    "status": "pending",
    "createdOn": "2024-01-01T07:00:14.127Z",
    "lastModifiedOn": "2024-01-01T07:00:14.1267785Z",
    "executionOrder": "anyOrder",
    "minRequiredApprovers": 1,
    "blockedApprovers": [],
    "_links": {
        "self": {
            "href": "AN_HREF_HERE" 
        }
    },
    "pipeline": {
        "owner": {
            "_links": {
                "web": {
                    "href": A_LINK_TO_THE_BUILD_HERE
                },
                "self": {
                    "href": "<REDACTED>
                }
            },
            "id": 149350,
            "name": "<REDACTED>"
        },
        "id": "413",
        "name": "Retag Images"
    }
}

The Go type in the SDK doesn't include the corresponding pipeline type and it would be really nice if it was included to simplify making additional REST calls to get the actual data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant