Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Connection Dialog DB drop down follow-up issues #623

Closed
5 of 6 tasks
kburtram opened this issue Feb 7, 2018 · 1 comment · Fixed by #662
Closed
5 of 6 tasks

Connection Dialog DB drop down follow-up issues #623

kburtram opened this issue Feb 7, 2018 · 1 comment · Fixed by #662
Assignees
@abist
Labels
Area - Connection Task
Milestone
March Public Preview

Comments

@kburtram
Copy link
Member

kburtram commented Feb 7, 2018 •
edited by abist
Loading

  • Drop down arrow icon doesn't look like other drop down icons on dialog
  • Vertical alignment and spacing doesn't match other select controls
  • Items aren't sorted alphabetically
  • Test keyboard UX for connection dialog
  • Fix bug where pressing ESC button would leave the dropdown open and close the dialog.
  • Make the selection theming consistent with the other dropdowns in the Connection Dialog.
@kburtram kburtram added this to the March Public Preview milestone Feb 7, 2018
@kburtram
Copy link
Member Author

kburtram commented Feb 7, 2018

@abist this issue captures the follow-up items discussed in this PR #583. Please add any additional tasks your tracking related to dropdown DB control.

@kburtram kburtram mentioned this issue Feb 7, 2018
Closed
@abist abist mentioned this issue Feb 12, 2018
Merged
@adsbot adsbot bot locked and limited conversation to collaborators Mar 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@abist abist

Labels
Area - Connection Task
Projects
None yet
Milestone
March Public Preview
Development

Successfully merging a pull request may close this issue.

Connection Dialog: Database dropdown followup issues fix microsoft/azuredatastudio
2 participants
@kburtram @abist