[botbuilder-dialogs] Waterfall dialogs do not log telemetry on reason===replaceCalled

[alexrecuenco]

Versions

• Botbuilder version 4.1.6
• Node version 14.16.1

Describe the bug

Telemetry is not logged if a waterfall dialog ends with replaceCalled, instead of endCalled or cancelCalled.

To Reproduce

Steps to reproduce the behavior:

1. Start dialog with a console log telemetry
2. End dialog with replace called
3. End dialog will not get logged

Expected behavior

When a dialog ends through replaceCalled, telemetry should be logged.

Additional context

I imagine this is a slight oversight in the endDialog method of waterfallDialog, but it might've been done on purpose, in which case, I am sorry.

[srinaath]

@alexrecuenco This seems to be a really old version of botbuilder-js (3 years ago). This repo has undergone massive upgrades since then and the bug could be resolved in the latest version. Is there a reason for you to not upgrade to 4.14.0?

@joshgummersall

[alexrecuenco]

@srinaath
Sorry, this is currently an issue on the main branch. https://github.com/microsoft/botbuilder-js/blob/b1d137f86aa2beb0642e85ed3398d147dd5c7d0e/libraries/botbuilder-dialogs/src/waterfallDialog.ts#L296

I put as version number the number on the package.json on the folder of botbuilder-dialogs, which I now realize was incorrect

[joshgummersall]

@alexrecuenco we maintain parity with the .NET SDK, which has the same behavior. I'll transfer this issue to the SDK repo where it'll get some visibility. I suspect this was an intentional design decision though and is not a bug.

[lauren-mills]

@mrivera-ms - Could you comment on whether this behavior is a bug or by design?

[alexrecuenco]

It has been some time, any updates?

[tdurnford]

@gabog Do you have any updates on this issue?

[carlosscastro]

@gabog can we assign a release for this issue or prioritize according to its urgency? Thanks

[gabog]

I added the the feature request to our backlog, as a workaround, you can override the method and log the event until this is added to the SDK