Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add stealth appearance to fluent-select #4953

Closed
RehanSaeed opened this issue Jul 12, 2021 · 4 comments · Fixed by microsoft/fluentui#19263
Closed

feat: add stealth appearance to fluent-select #4953

RehanSaeed opened this issue Jul 12, 2021 · 4 comments · Fixed by microsoft/fluentui#19263
Labels
community:noteworthy An issue or PR of particular interest to the community or planned for an announcement. community:request Issues specifically reported by a member of the community. improvement A non-feature-adding improvement status:under-consideration Issue is being reviewed by the team.

Comments

@RehanSaeed
Copy link

🙋 Feature Request

I'd like the fluent-select to have a stealth appearance.

🤔 Expected Behavior

There should be no border around the component and a stealth background colour should be added on hover.

😯 Current Behavior

There is no appearance attribute like some other components have.

@RehanSaeed RehanSaeed added the status:triage New Issue - needs triage label Jul 12, 2021
@EisenbergEffect EisenbergEffect added area:fast-components community:noteworthy An issue or PR of particular interest to the community or planned for an announcement. community:request Issues specifically reported by a member of the community. improvement A non-feature-adding improvement status:under-consideration Issue is being reviewed by the team. and removed status:triage New Issue - needs triage labels Jul 12, 2021
@EisenbergEffect
Copy link
Contributor

/cc @bheston for consideration.

@chrisdholt
Copy link
Member

/cc @bheston for consideration.

This is probably also a larger "fluent" conversation. I think one possible issue here could be WCAG requirements for inputs and controls - definitely something to look at as we consider.

@bheston
Copy link
Collaborator

bheston commented Aug 13, 2021

The request is for fluent-select but this came in under FAST. I want to confirm the is for Fluent. The 'stealth' appearance is one of the new select appearances, so I've added it to my open styling PR microsoft/fluentui#19263.

FAST still doesn't have support for appearances on Select, which I think would be beneficial. Leaving this open for a bit for anyone in the community to comment until we get a chance to restyle the FAST controls.

@RehanSaeed
Copy link
Author

I raised this for:

import { FluentSelect } from @fluentui/web-components;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community:noteworthy An issue or PR of particular interest to the community or planned for an announcement. community:request Issues specifically reported by a member of the community. improvement A non-feature-adding improvement status:under-consideration Issue is being reviewed by the team.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants