-
Notifications
You must be signed in to change notification settings - Fork 518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Combine pairs of DateTime predicates on the same search parameter #3903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feordin
added
Enhancement
Enhancement on existing functionality.
Area-SQL
Area related to the SQL Server data provider
Azure Healthcare APIs
Label denotes that the issue or PR is relevant to the FHIR service in the Azure Healthcare APIs
labels
Jun 6, 2024
test/Microsoft.Health.Fhir.Shared.Tests.E2E/Rest/Search/DateSearchTests.cs
Dismissed
Show dismissed
Hide dismissed
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
rajithaalurims
approved these changes
Jun 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested different scenarios of date search with this PR and got results as expected, so approving.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Area-SQL
Area related to the SQL Server data provider
Azure Healthcare APIs
Label denotes that the issue or PR is relevant to the FHIR service in the Azure Healthcare APIs
Enhancement
Enhancement on existing functionality.
Schema Version unchanged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When we have a FHIR query like the following:
?issued=ge2024-04-22T00:00:00&issued=lt2024-04-23T00:00:00
We currently generate two CTE's in SQL and then join them. This is inefficient and can be improved if we combine the two conditions into one CTE.
Related issues
Addresses [issue AB#121039].
Testing
Manually tested against the example query. All other automated tests run for regression testing.
FHIR Team Checklist
Semver Change (docs)
Patch|Skip|Feature|Breaking (reason)