New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for timing out SQL integration tests #3917

Merged

SergeyGaluzo merged 26 commits into main from users/sergal/integration

Jun 17, 2024

Contributor

SergeyGaluzo commented Jun 12, 2024 •

edited

Loading

Removes "database memory" from store processing flags.
Removes retries from store processing flags.
Changes database names to [FHIR Version]-[Test]-[DateTime]-[GUID]
Increases parallelism from 4 to 14 (should be less than 64/4)
Fixes database name uniqueness for some tests which were creating database with internally set name.
Adds more waits for tests affected by increased parallelism.
Adjusts min schema versions to currently deployed in production.

SergeyGaluzo added 2 commits

June 12, 2024 12:56


          Add version

c731ece


          reduced timeout on delete and reduced retries on create

3f0431a

SergeyGaluzo requested a review from a team as a code owner

June 12, 2024 19:58

SergeyGaluzo added 3 commits

June 12, 2024 14:02


          new name

593e7f1


          Merge branch 'main' into users/sergal/integration

39d5a86


          force unique database name

bc1df86

microsoft deleted a comment from azure-pipelines bot

SergeyGaluzo added 5 commits

June 12, 2024 16:42


          one more unique name

67c43f6


          disable drop

22a096e


          Semaphore removed

fb339a9


          skip drop if azure

0d0a042


          100 on custom query

2e0bd62

github-advanced-security bot found potential problems

View reviewed changes

...Microsoft.Health.Fhir.Shared.Tests.Integration/Persistence/SqlServerFhirStorageTestHelper.cs Fixed Show fixed Hide fixed

SergeyGaluzo added 2 commits

June 13, 2024 10:17


          SQL Azure in correct order

a65b40b


          oops

a9d1308

microsoft deleted a comment from azure-pipelines bot

SergeyGaluzo added 3 commits

June 13, 2024 11:57


          simpler is azure

8c53897


          revert semaphore

e3b9615


          semaphore 32

bd92853

SergeyGaluzo changed the title ~~[Do not review] Users/sergal/integration~~ Fix for timing out SQL integration tests

SergeyGaluzo added Enhancement Azure Healthcare APIs Schema Version unchanged labels

SergeyGaluzo added this to the S138 milestone

fhibf previously approved these changes

View reviewed changes

github-advanced-security bot found potential problems

View reviewed changes

...Microsoft.Health.Fhir.Shared.Tests.Integration/Persistence/SqlServerFhirStorageTestHelper.cs Fixed Show fixed Hide fixed

ca4a654

SergeyGaluzo dismissed fhibf’s stale review via

ca4a654

June 13, 2024 20:37

LTA-Thinking previously approved these changes

View reviewed changes

brendankowitz reviewed

View reviewed changes

...red.Tests.Integration/Features/ChangeFeed/SqlServerFhirResourceChangeCaptureDisabledTests.cs Outdated Show resolved Hide resolved

brendankowitz reviewed

View reviewed changes

...Microsoft.Health.Fhir.Shared.Tests.Integration/Persistence/SqlServerFhirStorageTestHelper.cs Outdated

@@ @@ -211,7 +211,7 @@ public async Task ExecuteSqlCmd(string sql) @@
                       public async Task DeleteDatabase(string databaseName, CancellationToken cancellationToken = default)
                       {
-                          if (!DropDatabase)
+                          if (IsAzure())

Member

brendankowitz Jun 13, 2024

Why don't we attempt to delete database when in Azure?

Contributor Author

SergeyGaluzo Jun 13, 2024

Because tests will start timing out, even though I decreased command timeout to 15 seconds.

SergeyGaluzo and others added 2 commits

June 13, 2024 14:02


          Removed unneccessary interpolation

05f61ca


          Update test/Microsoft.Health.Fhir.Shared.Tests.Integration/Features/C…

09c3664

…hangeFeed/SqlServerFhirResourceChangeCaptureDisabledTests.cs

Co-authored-by: Brendan Kowitz <bkowitz@microsoft.com>

SergeyGaluzo dismissed LTA-Thinking’s stale review via

09c3664

June 13, 2024 21:10


          Merge branch 'users/sergal/integration' of https://github.com/microso…

9757d12

…ft/fhir-server into users/sergal/integration

feordin previously approved these changes

View reviewed changes

azure-pipelines bot commented Jun 13, 2024

Azure Pipelines successfully started running 1 pipeline(s).

2 similar comments

azure-pipelines bot commented Jun 14, 2024

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines bot commented Jun 14, 2024

Azure Pipelines successfully started running 1 pipeline(s).


          Drop dbs yml

f3568e6

SergeyGaluzo dismissed feordin’s stale review via

f3568e6

June 14, 2024 21:15

SergeyGaluzo added 4 commits

June 15, 2024 10:21


          simple loop

3d490ca


          adjusted min version

582dc35


          drop in separate job

b5943cf


          120->240

04ce895

azure-pipelines bot commented Jun 16, 2024

Azure Pipelines successfully started running 1 pipeline(s).

2 similar comments

azure-pipelines bot commented Jun 16, 2024

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines bot commented Jun 16, 2024

Azure Pipelines successfully started running 1 pipeline(s).


          True fix

5a233fa

github-advanced-security bot found potential problems

View reviewed changes

src/Microsoft.Health.Fhir.SqlServer/Features/Storage/SqlServerFhirDataStore.cs Dismissed Show dismissed Hide dismissed

src/Microsoft.Health.Fhir.SqlServer/Features/Storage/SqlServerFhirDataStore.cs Dismissed Show dismissed Hide dismissed


          Removed delete job

3fc42d6

SergeyGaluzo enabled auto-merge (squash)

June 16, 2024 16:29

azure-pipelines bot commented Jun 16, 2024

Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment

azure-pipelines bot commented Jun 16, 2024

Azure Pipelines successfully started running 1 pipeline(s).

LTA-Thinking approved these changes

View reviewed changes

SergeyGaluzo merged commit e5c679d into main

46 of 52 checks passed

SergeyGaluzo deleted the users/sergal/integration branch

June 17, 2024 15:53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Azure Healthcare APIs Enhancement Schema Version unchanged