-
Notifications
You must be signed in to change notification settings - Fork 518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed search parameter init to run every schema upgrade #3926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikaelweave
added
Azure Healthcare APIs
Label denotes that the issue or PR is relevant to the FHIR service in the Azure Healthcare APIs
Bug
Bug bug bug.
labels
Jun 17, 2024
...lth.Fhir.Shared.Tests.Integration/Persistence/SqlServerSearchParameterInitializationTests.cs
Fixed
Show fixed
Hide fixed
...lth.Fhir.Shared.Tests.Integration/Persistence/SqlServerSearchParameterInitializationTests.cs
Fixed
Show fixed
Hide fixed
mikaelweave
changed the title
Updated search parameters init to run for every schema upgrade on uni…
Fixed search parameter initialization to run every schema upgrade
Jun 17, 2024
mikaelweave
changed the title
Fixed search parameter initialization to run every schema upgrade
Changed search parameter initialization to run every schema upgrade
Jun 17, 2024
mikaelweave
changed the title
Changed search parameter initialization to run every schema upgrade
Changed search parameter init to run every schema upgrade
Jun 17, 2024
rbans96
reviewed
Jun 18, 2024
src/Microsoft.Health.Fhir.SqlServer/Features/Storage/SqlServerFhirModel.cs
Show resolved
Hide resolved
rbans96
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Azure Healthcare APIs
Label denotes that the issue or PR is relevant to the FHIR service in the Azure Healthcare APIs
Bug
Bug bug bug.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changed search parameter initialization to run for every schema upgrade. This the fixes scenario when schema management runs before the FHIR Service runs. Also adds stability my making search parameter initialization idempotent.
Related issues
Addresses AB#119890
Testing
Integration testing, manual testing.
FHIR Team Checklist
Semver Change (docs)
Patch|Skip|Feature|Breaking (reason)