Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed search parameter init to run every schema upgrade #3926

Merged
merged 8 commits into from
Jun 18, 2024

Conversation

mikaelweave
Copy link
Contributor

@mikaelweave mikaelweave commented Jun 14, 2024

Description

Changed search parameter initialization to run for every schema upgrade. This the fixes scenario when schema management runs before the FHIR Service runs. Also adds stability my making search parameter initialization idempotent.

Related issues

Addresses AB#119890

Testing

Integration testing, manual testing.

FHIR Team Checklist

  • Update the title of the PR to be succinct and less than 65 characters
  • Add a milestone to the PR for the sprint that it is merged (i.e. add S47)
  • Tag the PR with the type of update: Bug, Build, Dependencies, Enhancement, New-Feature or Documentation
  • Tag the PR with Open source, Azure API for FHIR (CosmosDB or common code) or Azure Healthcare APIs (SQL or common code) to specify where this change is intended to be released.
  • Tag the PR with Schema Version backward compatible or Schema Version backward incompatible or Schema Version unchanged if this adds or updates Sql script which is/is not backward compatible with the code.
  • CI is green before merge Build Status
  • Review squash-merge requirements

Semver Change (docs)

Patch|Skip|Feature|Breaking (reason)

@mikaelweave mikaelweave added this to the S142 milestone Jun 17, 2024
@mikaelweave mikaelweave added Azure Healthcare APIs Label denotes that the issue or PR is relevant to the FHIR service in the Azure Healthcare APIs Bug Bug bug bug. labels Jun 17, 2024
@mikaelweave mikaelweave marked this pull request as ready for review June 17, 2024 22:28
@mikaelweave mikaelweave requested a review from a team as a code owner June 17, 2024 22:28
@mikaelweave mikaelweave changed the title Updated search parameters init to run for every schema upgrade on uni… Fixed search parameter initialization to run every schema upgrade Jun 17, 2024
@mikaelweave mikaelweave changed the title Fixed search parameter initialization to run every schema upgrade Changed search parameter initialization to run every schema upgrade Jun 17, 2024
@mikaelweave mikaelweave changed the title Changed search parameter initialization to run every schema upgrade Changed search parameter init to run every schema upgrade Jun 17, 2024
@mikaelweave mikaelweave enabled auto-merge (squash) June 18, 2024 21:59
@mikaelweave mikaelweave merged commit a8bd487 into main Jun 18, 2024
47 checks passed
@mikaelweave mikaelweave deleted the personal/mikaelw/fix-searchparam-init branch June 18, 2024 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure Healthcare APIs Label denotes that the issue or PR is relevant to the FHIR service in the Azure Healthcare APIs Bug Bug bug bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants