-
Notifications
You must be signed in to change notification settings - Fork 518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update sql server password to MI #3946
Conversation
We also want to update these settings in the Storage resource to {
"name": "[variables('storageAccountName')]",
"type": "Microsoft.Storage/storageAccounts",
"apiVersion": "2019-06-01",
"location": "[resourceGroup().location]",
"properties": {
"supportsHttpsTrafficOnly": true,
"allowBlobPublicAccess": false,
"allowSharedKeyAccess": false
},
"condition": "[variables('enableIntegrationStore')]",
"dependsOn": [],
"sku": {
"name": "Standard_LRS"
},
"kind": "Storage",
"tags": {}
} |
As part of deployment we'll need to make some minor edits to this file so we can update CI environment when the PR is merged: fhir-server/build/ci-deploy.yml Lines 65 to 74 in ec9f656
|
c270d65
to
0fc1995
Compare
We should also make the update Brendan mentioned above to CI deploy. |
Description
This PR introduces the use of Managed Identity for authentication to SQL Server, eliminating the need for a password in OSS.
Related issues
Addresses issue AB#96639.
Testing
Manual test deployment.
FHIR Team Checklist
Semver Change (docs)
Patch|Skip|Feature|Breaking (reason)