Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Storage Account Keys and SQL Passwords from Tests #3959

Merged
merged 72 commits into from
Jul 15, 2024

Conversation

mikaelweave
Copy link
Contributor

@mikaelweave mikaelweave commented Jul 11, 2024

Description

Updates SQL and Storage tests to use service connection to Azure for auth vs key/password methods. This change requires:

  • Changing auth to use AzurePipelinesCredential
  • Adding a custom SQL auth provider since SQL doesn't support this credential scenario.
  • Deploying a new SQL Server for integration tests. We can't use the same server because:
  • Disabled 3 blocking tests and created work item.

Related issues

AB#122686

Testing

  • PR pipeline is passing

FHIR Team Checklist

  • Update the title of the PR to be succinct and less than 65 characters
  • Add a milestone to the PR for the sprint that it is merged (i.e. add S47)
  • Tag the PR with the type of update: Bug, Build, Dependencies, Enhancement, New-Feature or Documentation
  • Tag the PR with Open source, Azure API for FHIR (CosmosDB or common code) or Azure Healthcare APIs (SQL or common code) to specify where this change is intended to be released.
  • Tag the PR with Schema Version backward compatible or Schema Version backward incompatible or Schema Version unchanged if this adds or updates Sql script which is/is not backward compatible with the code.
  • CI is green before merge Build Status
  • Review squash-merge requirements

Semver Change (docs)

Patch|Skip|Feature|Breaking (reason)

@mikaelweave mikaelweave requested a review from a team as a code owner July 11, 2024 03:14

public class SqlAzurePipelinesWorkloadIdentityAuthenticationProvider : SqlAuthenticationProvider
{
private AzurePipelinesCredential _azurePipelinesCredential;

Check notice

Code scanning / CodeQL

Missed 'readonly' opportunity Note test

Field '_azurePipelinesCredential' can be 'readonly'.
@mikaelweave mikaelweave added Enhancement-Test Enhancement on tests. Open source This change is only relevant to the OSS code or release. labels Jul 15, 2024
@mikaelweave mikaelweave merged commit 6e566e1 into main Jul 15, 2024
47 of 48 checks passed
@mikaelweave mikaelweave deleted the personal/mikaelw/move-storagetest-account-key branch July 15, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement-Test Enhancement on tests. Open source This change is only relevant to the OSS code or release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants