Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQL Server managed identity authentication instead of secrets #3960

Closed
wants to merge 2 commits into from

Conversation

v-ajajvanu
Copy link
Contributor

Description

Made changes to support Managed Identity Authentication for SQL Server DB instead of using Secrets.

Related issues

Addresses [issue 122770].

Testing

Tested by creating FHIR service instance using the updated ARM template.
Validated different settings after deployments.
Executed CRUD operations on FHIR service instance.
Executed Export operation on FHIR service instance.

FHIR Team Checklist

  • Update the title of the PR to be succinct and less than 65 characters
  • Add a milestone to the PR for the sprint that it is merged (i.e. add S47)
  • Tag the PR with the type of update: Bug, Build, Dependencies, Enhancement, New-Feature or Documentation
  • Tag the PR with Open source, Azure API for FHIR (CosmosDB or common code) or Azure Healthcare APIs (SQL or common code) to specify where this change is intended to be released.
  • Tag the PR with Schema Version backward compatible or Schema Version backward incompatible or Schema Version unchanged if this adds or updates Sql script which is/is not backward compatible with the code.
  • CI is green before merge Build Status
  • Review squash-merge requirements

Semver Change (docs)

Patch|Skip|Feature|Breaking (reason)

@v-ajajvanu v-ajajvanu added New Feature Label for a new feature in FHIR OSS Azure API for FHIR Label denotes that the issue or PR is relevant to the Azure API for FHIR labels Jul 11, 2024
@v-ajajvanu v-ajajvanu added this to the S145 milestone Jul 11, 2024
@v-ajajvanu v-ajajvanu requested a review from a team as a code owner July 11, 2024 06:41
@mikaelweave
Copy link
Contributor

Hi @v-ajajvanu, we have a PR below that I think already does this using a user assigned managed identity. Can you see if this is similar?

#3946

@v-ajajvanu
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@v-ajajvanu
Copy link
Contributor Author

@mikaelweave Indeed, the changes in this PR and the ones in PR #3946 are comparable. The only thing that was different was that we were utilizing a system-assigned identity, designating it as the primary user for SQL Server, and modifying the connection string in Key Vault to switch the authentication property to "Active Directory Managed Identity" and delete the user ID and password.

This PR is no longer required because the modifications indicated in PR 3946 have already been merged into the main branch.

Kindly refrain from merging this PR's changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure API for FHIR Label denotes that the issue or PR is relevant to the Azure API for FHIR New Feature Label for a new feature in FHIR OSS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants