Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement(import):Import should error for SearchParameter #3972

Merged
merged 3 commits into from
Jul 24, 2024
Merged

Enhancement(import):Import should error for SearchParameter #3972

merged 3 commits into from
Jul 24, 2024

Conversation

nathanlemma
Copy link
Contributor

@nathanlemma nathanlemma commented Jul 18, 2024 •
edited
Loading

Description

US 121465: Import should report "SearchParameter" type resources as error
Handle the following cases

  • If the type = "SearchParameter", the $import request should return HTTP 400 Bad Request
  • During import processing, for mixed files, error if a search parameter is encountered.

Related issues

Addresses [issue #121465].

Testing

Describe how this change was tested.

FHIR Team Checklist

  • Update the title of the PR to be succinct and less than 65 characters
  • Add a milestone to the PR for the sprint that it is merged (i.e. add S47)
  • Tag the PR with the type of update: Bug, Build, Dependencies, Enhancement, New-Feature or Documentation
  • Tag the PR with Open source, Azure API for FHIR (CosmosDB or common code) or Azure Healthcare APIs (SQL or common code) to specify where this change is intended to be released.
  • Tag the PR with Schema Version backward compatible or Schema Version backward incompatible or Schema Version unchanged if this adds or updates Sql script which is/is not backward compatible with the code.
  • CI is green before merge Build Status
  • Review squash-merge requirements

Semver Change (docs)

Patch|Skip|Feature|Breaking (reason)

@nathanlemma nathanlemma requested a review from a team as a code owner July 18, 2024 01:13
@nathanlemma nathanlemma requested a review from mikaelweave July 18, 2024 01:13
github-advanced-security[bot]
github-advanced-security bot found potential problems Jul 18, 2024
View reviewed changes
...Microsoft.Health.Fhir.Core.UnitTests/Features/Operations/Import/ImportResourceLoaderTests.cs
return ex.Message;
});

Func<long, long> idGenerator = (i) => i;

Check warning

Code scanning / CodeQL

Useless assignment to local variable Warning

This assignment to
idGenerator
Loading
is useless, since its value is never read.
@mikaelweave mikaelweave added the Azure Healthcare APIs Label denotes that the issue or PR is relevant to the FHIR service in the Azure Healthcare APIs label Jul 18, 2024
@mikaelweave mikaelweave added this to the S145 milestone Jul 18, 2024
@nathanlemma nathanlemma changed the title feature(import): Import should report "SearchParameter" type as error feature(import): Import should report SearchParameter type as error Jul 19, 2024
@nathanlemma nathanlemma changed the title feature(import): Import should report SearchParameter type as error Enhancement(import):Import should error for SearchParameter Jul 19, 2024
@nathanlemma nathanlemma added the Enhancement Enhancement on existing functionality. label Jul 19, 2024
mikaelweave
mikaelweave requested changes Jul 22, 2024
View reviewed changes
Copy link
Contributor

@mikaelweave mikaelweave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple small changes, then we'll be good 👍🏽

src/Microsoft.Health.Fhir.Core/Features/Operations/Import/ImportResourceLoader.cs Outdated Show resolved Hide resolved
...Microsoft.Health.Fhir.Core.UnitTests/Features/Operations/Import/ImportResourceLoaderTests.cs Outdated Show resolved Hide resolved
mikaelweave
mikaelweave approved these changes Jul 22, 2024
View reviewed changes
Copy link
Contributor

@mikaelweave mikaelweave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!! Thanks!

@nathanlemma nathanlemma force-pushed the 121465_import_searchParameter branch from 7236685 to 26cdd5e Compare July 24, 2024 16:46
@nathanlemma nathanlemma merged commit b293151 into main Jul 24, 2024
47 checks passed
@nathanlemma nathanlemma deleted the 121465_import_searchParameter branch July 24, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikaelweave mikaelweave mikaelweave approved these changes

Assignees
No one assigned
Labels
Azure Healthcare APIs Label denotes that the issue or PR is relevant to the FHIR service in the Azure Healthcare APIs Enhancement Enhancement on existing functionality.
Projects
None yet
Milestone
S145
Development

Successfully merging this pull request may close these issues.
2 participants
@nathanlemma @mikaelweave