Add database setting to reuse query plans #3991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SergeyGaluzo
added
Enhancement
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
src/Microsoft.Health.Fhir.SqlServer/Features/Search/SqlServerSearchService.cs
Fixed
Show fixed
Hide fixed
src/Microsoft.Health.Fhir.SqlServer/Features/Storage/SqlServerFhirDataStore.cs
Dismissed
Show dismissed
Hide dismissed
src/Microsoft.Health.Fhir.SqlServer/Features/Storage/SqlServerFhirDataStore.cs
Dismissed
Show dismissed
Hide dismissed
src/Microsoft.Health.Fhir.SqlServer/Features/Storage/SqlServerFhirDataStore.cs
Dismissed
Show dismissed
Hide dismissed
...lth.Fhir.SqlServer/Features/Search/Expressions/Visitors/QueryGenerators/SqlQueryGenerator.cs
Fixed
Show fixed
Hide fixed
src/Microsoft.Health.Fhir.SqlServer/Features/Storage/SqlServerFhirDataStore.cs
Dismissed
Show dismissed
Hide dismissed
src/Microsoft.Health.Fhir.SqlServer/Features/Storage/SqlServerFhirDataStore.cs
Dismissed
Show dismissed
Hide dismissed
src/Microsoft.Health.Fhir.SqlServer/Features/Storage/SqlServerFhirDataStore.cs
Dismissed
Show dismissed
Hide dismissed
src/Microsoft.Health.Fhir.SqlServer/Features/Storage/ProcessingFlag.cs
Dismissed
Show dismissed
Hide dismissed
src/Microsoft.Health.Fhir.SqlServer/Features/Storage/ProcessingFlag.cs
Dismissed
Show dismissed
Hide dismissed
src/Microsoft.Health.Fhir.SqlServer/Features/Search/SqlServerSearchService.cs
Fixed
Show fixed
Hide fixed
...lth.Fhir.SqlServer/Features/Search/Expressions/Visitors/QueryGenerators/SqlQueryGenerator.cs
Dismissed
Show dismissed
Hide dismissed
|
|
||
| namespace Microsoft.Health.Fhir.SqlServer.Features.Storage | ||
| { | ||
| internal class ProcessingFlag<TLogger> |
There was a problem hiding this comment.
Why is ProcessingFlag class using another class's logger?
There was a problem hiding this comment.
I just kept current behavior when moved ProcessingFlag from private to internal. Does it hurt?
BTW That is what we do in other places. See CustomQueries, for example, which takes search service logger.
src/Microsoft.Health.Fhir.SqlServer/Features/Search/SqlServerSearchService.cs
Dismissed
Show dismissed
Hide dismissed
src/Microsoft.Health.Fhir.SqlServer/Features/Search/SqlServerSearchService.cs
Dismissed
Show dismissed
Hide dismissed
LTA-Thinking
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://microsofthealth.visualstudio.com/Health/_workitems/edit/123488/
FYI Does not contain replacement of EXISTS by JOIN.