-
Notifications
You must be signed in to change notification settings - Fork 518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow reindex with unlimited empty pages #4663
Merged
mikaelweave
merged 4 commits into
main
from
personal/mikaelw/reindex-empty-pages-small-jobs
Oct 10, 2024
Merged
Allow reindex with unlimited empty pages #4663
mikaelweave
merged 4 commits into
main
from
personal/mikaelw/reindex-empty-pages-small-jobs
Oct 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikaelweave
added
Bug
Bug bug bug.
Azure Healthcare APIs
Label denotes that the issue or PR is relevant to the FHIR service in the Azure Healthcare APIs
labels
Oct 9, 2024
mikaelweave
changed the title
Allow reindex with large history in range
Allow reindex with unlimited empty pages
Oct 9, 2024
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
SergeyGaluzo
previously approved these changes
Oct 9, 2024
src/Microsoft.Health.Fhir.SqlServer/Features/Search/SqlServerSearchService.cs
Outdated
Show resolved
Hide resolved
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
src/Microsoft.Health.Fhir.SqlServer/Features/Search/SqlServerSearchService.cs
Show resolved
Hide resolved
src/Microsoft.Health.Fhir.SqlServer/Features/Search/SqlServerSearchService.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Health.Fhir.SqlServer/Features/Search/SqlServerSearchService.cs
Show resolved
Hide resolved
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
LTA-Thinking
approved these changes
Oct 10, 2024
mikaelweave
deleted the
personal/mikaelw/reindex-empty-pages-small-jobs
branch
October 10, 2024 15:25
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Azure Healthcare APIs
Label denotes that the issue or PR is relevant to the FHIR service in the Azure Healthcare APIs
Bug
Bug bug bug.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes artificial limitation of reindex where there is large historical datasets or customer wants limited query size.
Customer has tested my reindex fix from the last release and it's not quite right. It doesn't allow for many sequential historical/deleted resources with default query size. The reindex still says completed incorrectly in this case. This change adds an outer loop to continue getting surrogate ranges until there is one w/ data.
Related issues
AB#124883
FHIR Team Checklist
Semver Change (docs)
Patch|Skip|Feature|Breaking (reason)