Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow reindex with unlimited empty pages #4663

Merged
merged 4 commits into from
Oct 10, 2024

Conversation

mikaelweave
Copy link
Contributor

@mikaelweave mikaelweave commented Oct 9, 2024

Description

Removes artificial limitation of reindex where there is large historical datasets or customer wants limited query size.

Customer has tested my reindex fix from the last release and it's not quite right. It doesn't allow for many sequential historical/deleted resources with default query size. The reindex still says completed incorrectly in this case. This change adds an outer loop to continue getting surrogate ranges until there is one w/ data.

Related issues

AB#124883

FHIR Team Checklist

  • Update the title of the PR to be succinct and less than 65 characters
  • Add a milestone to the PR for the sprint that it is merged (i.e. add S47)
  • Tag the PR with the type of update: Bug, Build, Dependencies, Enhancement, New-Feature or Documentation
  • Tag the PR with Open source, Azure API for FHIR (CosmosDB or common code) or Azure Healthcare APIs (SQL or common code) to specify where this change is intended to be released.
  • Tag the PR with Schema Version backward compatible or Schema Version backward incompatible or Schema Version unchanged if this adds or updates Sql script which is/is not backward compatible with the code.
  • CI is green before merge Build Status
  • Review squash-merge requirements

Semver Change (docs)

Patch|Skip|Feature|Breaking (reason)

@mikaelweave mikaelweave added Bug Bug bug bug. Azure Healthcare APIs Label denotes that the issue or PR is relevant to the FHIR service in the Azure Healthcare APIs labels Oct 9, 2024
@mikaelweave mikaelweave added this to the S151 milestone Oct 9, 2024
@mikaelweave mikaelweave requested a review from a team as a code owner October 9, 2024 04:15
@mikaelweave mikaelweave changed the title Allow reindex with large history in range Allow reindex with unlimited empty pages Oct 9, 2024
@mikaelweave
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

SergeyGaluzo
SergeyGaluzo previously approved these changes Oct 9, 2024
@mikaelweave
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mikaelweave
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mikaelweave mikaelweave enabled auto-merge (squash) October 9, 2024 22:08
@mikaelweave
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mikaelweave mikaelweave merged commit df29074 into main Oct 10, 2024
47 checks passed
@mikaelweave mikaelweave deleted the personal/mikaelw/reindex-empty-pages-small-jobs branch October 10, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure Healthcare APIs Label denotes that the issue or PR is relevant to the FHIR service in the Azure Healthcare APIs Bug Bug bug bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants