Batch size dependent retries for $import #4668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SergeyGaluzo
added
Enhancement
| } | ||
|
|
||
| ExecuteSql("TRUNCATE TABLE EventLog"); | ||
| ExecuteSql("DELETE FROM Resource"); |
There was a problem hiding this comment.
Is this going to affect other E2E tests since they run in parallel?
mikaelweave
reviewed
Oct 10, 2024
| _logger.LogWarning(e, $"Error on {nameof(ImportResourcesInternalAsync)} retries={{Retries}}", retries); | ||
| await Task.Delay(1000, cancellationToken); | ||
| _logger.LogWarning(e, $"Error on {nameof(ImportResourcesInternalAsync)} retries={{Retries}} resources={{Resources}}", retries, resources.Count); | ||
| await Task.Delay(retries > 3 ? 10 : 1000, cancellationToken); // if >3 assume that it is id generation problem |
There was a problem hiding this comment.
Would a different / more specific SQL error signal help us determine the reason for the conflict vs assuming on the number of retries?
There was a problem hiding this comment.
Yes. It would. This is more work than I want to do, and large number of retries indicates id collision with very high accuracy. This is true especially for $import that runs internal deduplication.
mikaelweave
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://microsofthealth.visualstudio.com/Health/_workitems/edit/129936